[Merged by Bors] - feat(data/int/basic algebra/associated): is_unit (a : ℤ) iff a = ±1 #7058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Apr 6, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
reviewed
Apr 6, 2021
adomani
added
the
awaiting-review
eric-wieser
reviewed
Apr 6, 2021
…/mathlib into adomani_int_nat_abs
eric-wieser
reviewed
Apr 6, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
You asked on the zulip thread about where a good place for lemma is_unit.neg {α : Type*} [ring α] {a : α} : is_unit a → is_unit (-a)
| ⟨x, hx⟩ := hx ▸ (-x).is_unit |
eric-wieser
reviewed
Apr 6, 2021
eric-wieser
reviewed
Apr 6, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
reviewed
Apr 6, 2021
|
✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Thank you for all your help! I will wait for CI to finish and will push the PR onto the queue! |
eric-wieser
added
delegated
|
Thanks 🎉 bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 6, 2021
…7058) Besides the title lemma, this PR also moves lemma `is_unit_int` from `algebra/associated` to `data/int/basic`. Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Ruben-VandeVelde <65514131+Ruben-VandeVelde@users.noreply.github.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Apr 7, 2021
…7058) Besides the title lemma, this PR also moves lemma `is_unit_int` from `algebra/associated` to `data/int/basic`. Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Ruben-VandeVelde <65514131+Ruben-VandeVelde@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides the title lemma, this PR also moves lemma
is_unit_intfromalgebra/associatedtodata/int/basic.Co-authored-by: Eric Wieser wieser.eric@gmail.com
Co-authored-by: Ruben Van de Velde 65514131+Ruben-VandeVelde@users.noreply.github.com