[Merged by Bors] - refactor(group_theory/order_of_element): use minimal_period for the definition #7082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Apr 7, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
adomani
reviewed
Apr 7, 2021
adomani
reviewed
Apr 7, 2021
Co-authored-by: damiano <adomani@gmail.com>
adomani
reviewed
Apr 7, 2021
Co-authored-by: damiano <adomani@gmail.com>
eric-wieser
reviewed
Apr 7, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
github-actions
bot
added
the
merge-conflict
github-actions
bot
added
merge-conflict
Merge branch 'master' into minimal_period
github-actions
bot
added
merge-conflict
github-actions
bot
removed
the
merge-conflict
jcommelin
approved these changes
Apr 30, 2021
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 30, 2021
…efinition (#7082) This PR redefines `order_of_element` in terms of `function.minimal_period`. It furthermore introduces a predicate on elements of a finite group to be of finite order. Co-authored by: Damiano Testa adomani@gmail.com Co-authored-by: Julian-Kuelshammer <68201724+Julian-Kuelshammer@users.noreply.github.com> Co-authored-by: adomani <adomani@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
May 1, 2021
…efinition (#7082) This PR redefines `order_of_element` in terms of `function.minimal_period`. It furthermore introduces a predicate on elements of a finite group to be of finite order. Co-authored by: Damiano Testa adomani@gmail.com Co-authored-by: Julian-Kuelshammer <68201724+Julian-Kuelshammer@users.noreply.github.com> Co-authored-by: adomani <adomani@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redefines
order_of_elementin terms offunction.minimal_period. It furthermore introduces a predicate on elements of a finite group to be of finite order.Co-authored by: Damiano Testa adomani@gmail.com