feat(order/sublattice): sublattice definition #7093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Apr 7, 2021
eric-wieser
reviewed
Apr 7, 2021
src/order/sublattice.lean
Outdated
| (inf : ∀ a b, f(a ⊓ b) = f(a) ⊓ f(b) ) | ||
| (sup : ∀ a b, f(a ⊔ b) = f(a) ⊔ f(b) ) | ||
| : | ||
| lattice L |
There was a problem hiding this comment.
This conclusion should be lattice β; you already have lattice L as an argument!
eric-wieser
added
awaiting-author
| Definition of sublattice based on typeclass of lattice | ||
| -/ | ||
|
|
||
| variables { L : Type* } [ lattice L ] { s : set L } |
There was a problem hiding this comment.
Here and below, we only put spaces around curly braces when they surround a list of tactics. See our style guide or check how other files in mathlib are formatted.
Suggested change
| variables { L : Type* } [ lattice L ] { s : set L } | |
| variables {L : Type*} [lattice L] {s : set L} |
Comment on lines
+16
to
+18
| ( carrier : set L) | ||
| ( inf_mem' {a b : L} : a ∈ carrier → b ∈ carrier → a ⊓ b ∈ carrier ) | ||
| ( sup_mem' {a b : L} : a ∈ carrier → b ∈ carrier → a ⊔ b ∈ carrier ) |
There was a problem hiding this comment.
We don't indent the first line after :=
Suggested change
| ( carrier : set L) | |
| ( inf_mem' {a b : L} : a ∈ carrier → b ∈ carrier → a ⊓ b ∈ carrier ) | |
| ( sup_mem' {a b : L} : a ∈ carrier → b ∈ carrier → a ⊔ b ∈ carrier ) | |
| (carrier : set L) | |
| (inf_mem' {a b : L} : a ∈ carrier → b ∈ carrier → a ⊓ b ∈ carrier) | |
| (sup_mem' {a b : L} : a ∈ carrier → b ∈ carrier → a ⊔ b ∈ carrier) |
eric-wieser
reviewed
Dec 10, 2021
Comment on lines
+55
to
+66
| /-- Trying to make definition of sublattice based on injective map | ||
| preserving structure to lattice -/ | ||
| protected def function.injective.sublattice [ lattice SL₂ ] [ has_inf SL₁ ] [ has_sup SL₁ ] | ||
| (f : SL₁ → SL₂ ) | ||
| (hf: injective f) | ||
| (inf : ∀ a b, f(a ⊓ b) = f(a) ⊓ f(b) ) | ||
| (sup : ∀ a b, f(a ⊔ b) = f(a) ⊔ f(b) ) : | ||
| sublattice SL₁ := | ||
| { sup_mem' := λ a b, , | ||
| inf_mem' := λ a b, , | ||
| carrier := | ||
| } |
There was a problem hiding this comment.
It's hard to tell exactly what was intended here, but #10615 might have added something relevant.
semorrison
added
the
too-late
|
Redone in Lean 4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definition of order/sublattice