Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/{algebra, module}/basic): make 3 multiplication by 1 simp lemmas #7166

Closed
wants to merge 3 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Apr 12, 2021

The three lemmas in the merged PR #7094 could be simp lemmas. This PR makes this suggestion.

While I was at it,

  • I moved one of the lemmas outside of the alg_hom namespace,
  • I fixed a typo in a doc string of a tutorial.

Zulip:
https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/trying.20out.20a.20.60simp.60.20lemma


Open in Gitpod

@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Apr 12, 2021
bors bot pushed a commit that referenced this pull request Apr 12, 2021
…imp` lemmas (#7166)

The three lemmas in the merged PR #7094 could be simp lemmas.  This PR makes this suggestion.

While I was at it,
* I moved one of the lemmas outside of the `alg_hom` namespace,
* I fixed a typo in a doc string of a tutorial.

Zulip:
https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/trying.20out.20a.20.60simp.60.20lemma
@semorrison semorrison changed the title feat(algebra/{algebra, module}/basic): make 3 smultiplication by 1 simp lemmas feat(algebra/{algebra, module}/basic): make 3 multiplication by 1 simp lemmas Apr 12, 2021
@bors
Copy link

bors bot commented Apr 12, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/{algebra, module}/basic): make 3 multiplication by 1 simp lemmas [Merged by Bors] - feat(algebra/{algebra, module}/basic): make 3 multiplication by 1 simp lemmas Apr 12, 2021
@bors bors bot closed this Apr 12, 2021
@bors bors bot deleted the adomani_simp_mul_one branch April 12, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants