[Merged by Bors] - chore(group/ring_hom): fix a nat nsmul diamond #7201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgouezel
added
the
awaiting-review
eric-wieser
reviewed
Apr 15, 2021
eric-wieser
reviewed
Apr 15, 2021
|
✌️ sgouezel can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 15, 2021
The space of additive monoid should be given a proper `nat`-action, by the pointwise action, to avoid diamonds. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
github-actions
bot
added
ready-to-merge
|
Build failed: |
|
I removed |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 15, 2021
The space of additive monoid should be given a proper `nat`-action, by the pointwise action, to avoid diamonds. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Apr 15, 2021
The space of additive monoid should be given a proper `nat`-action, by the pointwise action, to avoid diamonds. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The space of additive monoid should be given a proper
nat-action, by the pointwise action, to avoid diamonds.The only difficulty in the PR is that the file
algebra/group/hom.leancontaining the additive monoid instance on the space of morphisms comes before the filealgebra/group_power/basic, which contains all the useful properties ofnsmul. So, we split the filealgebra/group/hom.leaninto two, where the second part can come later in the import hierarchy (belowalgebra/group_power/basic), and we declare the instances in this second part.