Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/dfinsupp): copy map_range defs from finsupp #7293

Closed
wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

This adds the bundled homs:

  • dfinsupp.map_range.add_monoid_hom
  • dfinsupp.map_range.add_equiv
  • dfinsupp.map_range.linear_map
  • dfinsupp.map_range.linear_equiv

and lemmas

  • dfinsupp.map_range_zero
  • dfinsupp.map_range_add
  • dfinsupp.map_range_smul

For which we already have identical lemmas for finsupp.

Split from #7217, since map_range.add_equiv can be used in conjunction with submonoid.mrange_restrict


Open in Gitpod

@eric-wieser eric-wieser force-pushed the eric-wieser/dfinsupp.map_add_equiv branch from 8a951dd to 5ade410 Compare April 20, 2021 23:50
@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Apr 21, 2021
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 21, 2021
@eric-wieser
Copy link
Member Author

bors r+

bors forgot

bors bot pushed a commit that referenced this pull request Apr 21, 2021
This adds the bundled homs:

* `dfinsupp.map_range.add_monoid_hom`
* `dfinsupp.map_range.add_equiv`
* `dfinsupp.map_range.linear_map`
* `dfinsupp.map_range.linear_equiv`

and lemmas

* `dfinsupp.map_range_zero`
* `dfinsupp.map_range_add`
* `dfinsupp.map_range_smul`

For which we already have identical lemmas for `finsupp`.

Split from #7217, since `map_range.add_equiv` can be used in conjunction with `submonoid.mrange_restrict`
@bors
Copy link

bors bot commented Apr 21, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/dfinsupp): copy map_range defs from finsupp [Merged by Bors] - feat(data/dfinsupp): copy map_range defs from finsupp Apr 21, 2021
@bors bors bot closed this Apr 21, 2021
@bors bors bot deleted the eric-wieser/dfinsupp.map_add_equiv branch April 21, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants