New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(category_theory/abelian): biproducts of projective objects are projective #7319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
instance {P Q : C} [has_zero_morphisms C] [has_binary_biproduct P Q] | ||
[projective P] [projective Q] : | ||
projective (P ⊞ Q) := | ||
{ factors := λ E X' f e epi, by exactI | ||
⟨biprod.desc (factor_thru (biprod.inl ≫ f) e) (factor_thru (biprod.inr ≫ f) e), by tidy⟩, } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if this didn't need to be separately stated, let alone proved, and Lean just knew that biproducts were coproducts, but it doesn't seem easy in our current setup. :-(
Thanks 🎉 bors merge |
…rojective (#7319) Also all objects of `Type` are projective. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Pull request successfully merged into master. Build succeeded: |
Also all objects of
Type
are projective.