Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(category_theory/linear): linear functors #7369

Closed
wants to merge 6 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented Apr 26, 2021

@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 26, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels May 2, 2021
@github-actions
Copy link

github-actions bot commented May 2, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label May 2, 2021
@semorrison semorrison added the awaiting-review The author would like community review of the PR label May 2, 2021
Copy link
Collaborator

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my minor comment, this looks good to me!

@b-mehta b-mehta requested a review from jcommelin May 4, 2021 16:33
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want definitions (or even instances?) that show that additive functors are always {nat,int,rat}-linear.
(We have things like add_monoid_hom.to_{nat,int,rat}_linear_map if I'm not mistaken. So this should be easy.
@semorrison do you want to add those to this PR? Or a follow-up?

@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label May 6, 2021
@semorrison
Copy link
Collaborator Author

@jcommelin, done! I also relaxed some ring to semiring while I was at it, so we could actually say F.linear ℕ.

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label May 6, 2021
@jcommelin
Copy link
Member

if CI-passes then
bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 6, 2021
bors bot pushed a commit that referenced this pull request May 6, 2021


Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented May 6, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/linear): linear functors [Merged by Bors] - feat(category_theory/linear): linear functors May 6, 2021
@bors bors bot closed this May 6, 2021
@bors bors bot deleted the linear_functor branch May 6, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants