-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(category_theory/linear): linear functors #7369
Conversation
semorrison
commented
Apr 26, 2021
•
edited by github-actions
bot
Loading
edited by github-actions
bot
- depends on: [Merged by Bors] - feat(category_theory): definition of R-linear category #7321
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my minor comment, this looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want definitions (or even instances?) that show that additive functors are always {nat,int,rat}
-linear.
(We have things like add_monoid_hom.to_{nat,int,rat}_linear_map
if I'm not mistaken. So this should be easy.
@semorrison do you want to add those to this PR? Or a follow-up?
@jcommelin, done! I also relaxed some |
if CI-passes then |
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Pull request successfully merged into master. Build succeeded: |