Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory/*/projective): refactor treatment of projective objects #7485

Closed
wants to merge 36 commits into from
Closed

[Merged by Bors] - feat(category_theory/*/projective): refactor treatment of projective objects #7485

wants to merge 36 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented May 4, 2021 •
edited by github-actions bot

@semorrison
feat(category_theory/.../images): image.pre_comp_epi_of_epi
ce8b14e
@semorrison
feat(category_theory/.../zero): if a zero morphism is a mono, the sou…
2ab67aa 
…rce is zero
@semorrison
add simp lemmas
dc8ac57
@semorrison
feat(category_theory/preadditive): reformulation of mono_of_kernel_zero
25a6827
@semorrison
feat(category_theory/subobject): minor tweaks
6fa9bfe
@semorrison
Merge branch 'subobject2' into subobject_limits
62850b8
@semorrison
feat(category_theory/subobjects): more about kernel and image subobjects
d6169aa
@semorrison
minor
3caf09d
@semorrison
Merge branch 'subobject_limits' into homology_redesign
292109b
@semorrison
Merge branch 'subobject2' into subobject_limits
79e72a0
@semorrison
Merge branch 'subobject_limits' into homology_redesign
01f2cc4
@semorrison
Merge branch 'mono_of_kernel_iso_zero' into homology_redesign
723796d
@semorrison
Merge branch 'zero' into homology_redesign
a4635dc
@semorrison
feat(algebra/homology): redesign of homological complexes
b9c853b
@semorrison
oops
bc59d44
@semorrison
feat(category_theory/*/projective): refactor treatment of projective …
f2be42d 
…objects
@semorrison semorrison mentioned this pull request May 4, 2021
Closed
2 tasks
@semorrison @jcommelin
Apply suggestions from code review
683ac43 
Co-authored-by: Johan Commelin <johan@commelin.net>
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label May 4, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label May 11, 2021
@github-actions github-actions bot removed merge-conflict Please `git merge origin/master` then a bot will remove this label. blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels May 11, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@semorrison semorrison added the awaiting-review The author would like community review of the PR label May 11, 2021
jcommelin
jcommelin reviewed May 11, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but Markus is the expert on this stuff.

src/category_theory/preadditive/projective.lean Outdated Show resolved Hide resolved
src/category_theory/preadditive/projective.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin requested a review from TwoFX May 11, 2021 11:11
semorrison and others added 2 commits May 13, 2021 10:23
jcommelin
jcommelin approved these changes May 15, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 15, 2021
bors bot pushed a commit that referenced this pull request May 15, 2021
@semorrison @jcommelin
feat(category_theory/*/projective): refactor treatment of projective …
b4b38da 
…objects (#7485)




Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented May 15, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/*/projective): refactor treatment of projective objects [Merged by Bors] - feat(category_theory/*/projective): refactor treatment of projective objects May 15, 2021
@bors bors bot closed this May 15, 2021
@bors bors bot deleted the projective_refactor branch May 15, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@TwoFX TwoFX Awaiting requested review from TwoFX

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@semorrison @jcommelin