Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(category_theory/abelian): abelian categories with enough projectives have projective resolutions #7488

Closed
wants to merge 159 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented May 4, 2021

semorrison and others added 30 commits May 4, 2021 19:55
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. labels May 18, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label May 20, 2021
@semorrison semorrison added the awaiting-review The author would like community review of the PR label May 20, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels May 31, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label May 31, 2021
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 1, 2021
@bors
Copy link

bors bot commented Jun 1, 2021

Canceled.

@semorrison
Copy link
Collaborator Author

@jcommelin, sorry, that doc-string I added wasn't intended to be the entire explanation: I should have left a comment that more was coming.

In fact, the more that came was a complete rewrite, that doesn't jump through any strange hoops at all. We just use chain_complex.mk' and chain_complex.mk_hom in the completely standard way, hooray!

Could you please re-review?

@semorrison semorrison requested a review from jcommelin June 1, 2021 06:16
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! That looks much much better!

@jcommelin
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Jun 1, 2021

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Jun 1, 2021
@semorrison
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Jun 1, 2021
…ives have projective resolutions (#7488)




Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jun 2, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/abelian): abelian categories with enough projectives have projective resolutions [Merged by Bors] - feat(category_theory/abelian): abelian categories with enough projectives have projective resolutions Jun 2, 2021
@bors bors bot closed this Jun 2, 2021
@bors bors bot deleted the abelian_projective branch June 2, 2021 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants