Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(category_theory/monoidal): the definition of Tor #7512

Closed
wants to merge 202 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented May 5, 2021

Tor, the left-derived functor of tensor product

We define tor C n : C ⥤ C ⥤ C, by left-deriving in the second factor of (X, Y) ↦ X ⊗ Y.

For now we have almost nothing to say about it!
It would be good to show that this is naturally isomorphic to the functor obtained
by left-deriving in the first factor, instead.


Open in Gitpod

semorrison and others added 30 commits May 4, 2021 19:55
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. labels May 31, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jun 2, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jul 3, 2021
@github-actions
Copy link

github-actions bot commented Jul 3, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jul 3, 2021
@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label Jul 3, 2021
@jcommelin jcommelin requested a review from adamtopaz July 6, 2021 11:00
@jcommelin jcommelin self-assigned this Jul 6, 2021
Copy link
Collaborator

@adamtopaz adamtopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Here are just a few, mostly minor, comments.

src/category_theory/monoidal/category.lean Outdated Show resolved Hide resolved
src/category_theory/monoidal/category.lean Outdated Show resolved Hide resolved
src/category_theory/monoidal/preadditive.lean Outdated Show resolved Hide resolved
src/category_theory/monoidal/tor.lean Outdated Show resolved Hide resolved
src/category_theory/monoidal/tor.lean Show resolved Hide resolved
@adamtopaz adamtopaz added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 6, 2021
@semorrison semorrison added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 13, 2021
Copy link
Collaborator

@adamtopaz adamtopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 13, 2021
bors bot pushed a commit that referenced this pull request Jul 13, 2021
# Tor, the left-derived functor of tensor product

We define `tor C n : C ⥤ C ⥤ C`, by left-deriving in the second factor of `(X, Y) ↦ X ⊗ Y`.

For now we have almost nothing to say about it!
It would be good to show that this is naturally isomorphic to the functor obtained
by left-deriving in the first factor, instead.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jul 13, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/monoidal): the definition of Tor [Merged by Bors] - feat(category_theory/monoidal): the definition of Tor Jul 13, 2021
@bors bors bot closed this Jul 13, 2021
@bors bors bot deleted the tor branch July 13, 2021 20:10
b-mehta pushed a commit that referenced this pull request Jul 20, 2021
# Tor, the left-derived functor of tensor product

We define `tor C n : C ⥤ C ⥤ C`, by left-deriving in the second factor of `(X, Y) ↦ X ⊗ Y`.

For now we have almost nothing to say about it!
It would be good to show that this is naturally isomorphic to the functor obtained
by left-deriving in the first factor, instead.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants