Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix(tactic/derive_fintype): use correct universes #7581

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix(tactic/derive_fintype): use correct universes #7581

wants to merge 1 commit into from

Conversation

digama0
Copy link
Member

@digama0 digama0 commented May 11, 2021

Reported on Zulip.

@eric-wieser
Copy link
Member

I'm a little surprised this only has four minutes worth of dependencies to build.

@ericrbg
Copy link
Collaborator

ericrbg commented May 11, 2021

@eric-wieser, this works for deriving computable fintypes for →+* and such like! No need to do the ugly equivs that I did in #7363

@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label May 11, 2021
bors bot pushed a commit that referenced this pull request May 11, 2021
@digama0
fix(tactic/derive_fintype): use correct universes (#7581)
a7e1696 
Reported on [Zulip](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/type.20class.20error.20with.20mk_fintype_instance/near/238209823).
@bors
Copy link

bors bot commented May 12, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(tactic/derive_fintype): use correct universes [Merged by Bors] - fix(tactic/derive_fintype): use correct universes May 12, 2021
@bors bors bot closed this May 12, 2021
@bors bors bot deleted the derive_fintype_bug branch May 12, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@digama0 @eric-wieser @ericrbg @fpvandoorn