Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebraic_topology): cosimplicial objects #7614

Closed
wants to merge 3 commits into from

Conversation

semorrison
Copy link
Collaborator

Dualize the existing API for simplicial_object to provide cosimplicial_object, and move the contents of LTE's for_mathlib/simplicial/augmented.lean to mathlib.

Co-authored-by: Adam Topaz github@adamtopaz.com


Open in Gitpod

@semorrison semorrison requested a review from adamtopaz May 15, 2021 08:35
@semorrison semorrison added the awaiting-review The author would like community review of the PR label May 15, 2021
Copy link
Collaborator

@adamtopaz adamtopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worthwhile to add 1-2 sentences about cosimplicial objects in the module docstring. Aside from this and the very minor comment about parens, this looks good to me!

src/algebraic_topology/simplicial_object.lean Outdated Show resolved Hide resolved
@adamtopaz
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 15, 2021
bors bot pushed a commit that referenced this pull request May 15, 2021
Dualize the existing API for `simplicial_object` to provide `cosimplicial_object`, and move the contents of LTE's `for_mathlib/simplicial/augmented.lean` to mathlib.

Co-authored-by: Adam Topaz <github@adamtopaz.com>



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented May 16, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebraic_topology): cosimplicial objects [Merged by Bors] - feat(algebraic_topology): cosimplicial objects May 16, 2021
@bors bors bot closed this May 16, 2021
@bors bors bot deleted the cosimplicial branch May 16, 2021 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants