[Merged by Bors] - feat(scripts/lint-style.py): add linter that disables importing omega #7646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is supposed to fail on tactic.default
github-actions
bot
added
the
blocked-by-other-PR
github-actions
bot
removed
the
blocked-by-other-PR
bryangingechen
added
the
awaiting-author
github-actions
bot
added
blocked-by-other-PR
|
🎉 Great news! Looks like all the dependencies have been resolved:
💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
fpvandoorn
added
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
May 26, 2021
…#7646) * Files in mathlib are not allowed to `import tactic` or `import tactic.omega`. This adds a style linter to enforce this. * `tactic.default` is allowed to import `tactic.omega` (other files that only import other files are excluded from these checks, so a malicious user still could get around this linter, but it's hard to imagine this happening accidentally) * Remove `import tactic` from 3 files (in `archive/` and `test/`)
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import tacticorimport tactic.omega. This adds a style linter to enforce this.tactic.defaultis allowed to importtactic.omega(other files that only import other files are excluded from these checks, so a malicious user still could get around this linter, but it's hard to imagine this happening accidentally)import tacticfrom 3 files (inarchive/andtest/)import tactic.omega]import tactic.omega]Zulip