[Merged by Bors] - feat(algebraic_topology/simplicial_object): Some API for converting between simplicial and cosimplicial #7656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamtopaz
added
the
awaiting-review
semorrison
reviewed
May 19, 2021
semorrison
reviewed
May 19, 2021
semorrison
reviewed
May 19, 2021
semorrison
reviewed
May 19, 2021
Comment on lines
376
to
378
| have := f.w, | ||
| apply_fun (λ η, η.app x.unop) at this, | ||
| exact this.symm, |
There was a problem hiding this comment.
Suggested change
| have := f.w, | |
| apply_fun (λ η, η.app x.unop) at this, | |
| exact this.symm, | |
| exact (congr_app f.w x.unop).symm, |
Took me a while to remember that we added congr_app for exactly this awkwardness!
There was a problem hiding this comment.
Done! That's a useful one :)
semorrison
reviewed
May 19, 2021
Comment on lines
358
to
360
| have := f.unop.w, | ||
| apply_fun (λ η, η.app (op x)) at this, | ||
| exact this.symm, |
There was a problem hiding this comment.
Suggested change
| have := f.unop.w, | |
| apply_fun (λ η, η.app (op x)) at this, | |
| exact this.symm, | |
| exact (congr_app f.unop w (op x)).symm, |
|
Otherwise, looks great. bors d+ |
|
✌️ adamtopaz can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
…r-community/mathlib into simplicial_cosimplicial_equivs
|
bors r+ |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
May 19, 2021
…etween simplicial and cosimplicial (#7656) This adds some code which is helpful to convert back and forth between simplicial and cosimplicial object. For augmented objects, this doesn't follow directly from the existing API in `category_theory/opposite`. Co-authored-by: Adam Topaz <adamtopaz@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Vierkantor
pushed a commit
that referenced
this pull request
May 19, 2021
…etween simplicial and cosimplicial (#7656) This adds some code which is helpful to convert back and forth between simplicial and cosimplicial object. For augmented objects, this doesn't follow directly from the existing API in `category_theory/opposite`. Co-authored-by: Adam Topaz <adamtopaz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some code which is helpful to convert back and forth between simplicial and cosimplicial object.
For augmented objects, this doesn't follow directly from the existing API in
category_theory/opposite.