Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(order/conditionally_complete_lattice): add lemmas #7689

Closed
wants to merge 9 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented May 22, 2021

These lemmas names match the version that already exist without the c prefix.

This also renames finset.sup_eq_Sup to finset.sup_id_eq_Sup, and introduces a new finset.sup_eq_Sup_image.


Open in Gitpod

I found myself needing to construct this instance by hand somewhere; since we already need it to construct `unique true`, we may as well make a def.
@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label May 22, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label May 22, 2021
@eric-wieser eric-wieser changed the title chore(order/conditionally_complete_lattice): add lemmas feat(order/conditionally_complete_lattice): add lemmas May 23, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels May 23, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label May 24, 2021
@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 26, 2021
bors bot pushed a commit that referenced this pull request May 26, 2021
These lemmas names match the version that already exist without the `c` prefix.

This also renames `finset.sup_eq_Sup` to `finset.sup_id_eq_Sup`, and introduces a new `finset.sup_eq_Sup_image`.
@bors
Copy link

bors bot commented May 26, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/conditionally_complete_lattice): add lemmas [Merged by Bors] - feat(order/conditionally_complete_lattice): add lemmas May 26, 2021
@bors bors bot closed this May 26, 2021
@bors bors bot deleted the eric-wieser/finset.sup'_eq_csup branch May 26, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants