Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(measure_theory/measurable_space): add instances for subtypes #7702

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(measure_theory/measurable_space): add instances for subtypes #7702

wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

Open in Gitpod

Following up on this Zulip thread.

@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label May 24, 2021
fpvandoorn
fpvandoorn approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do we already want to already add the name event for subtype measurable_set?

@fpvandoorn
Copy link
Member

bors d+

@bors
Copy link

bors bot commented May 24, 2021

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels May 24, 2021
@eric-wieser
Copy link
Member Author

bors r+

I don't know enough about measure theory to be confident in proposing the name event in contexts that aren't probability, so would prefer not to do that in this PR.

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label May 25, 2021
bors bot pushed a commit that referenced this pull request May 25, 2021
@eric-wieser
feat(measure_theory/measurable_space): add instances for subtypes (#7702
bbf6150 
)
@bors
Copy link

bors bot commented May 25, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(measure_theory/measurable_space): add instances for subtypes [Merged by Bors] - feat(measure_theory/measurable_space): add instances for subtypes May 25, 2021
@bors bors bot closed this May 25, 2021
@bors bors bot deleted the eric-wieser/subtype-measurable_set branch May 25, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpvandoorn fpvandoorn fpvandoorn approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eric-wieser @fpvandoorn