Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/nnreal): filling out some lemmas #7710

Closed
wants to merge 1 commit into from

Conversation

semorrison
Copy link
Collaborator

From LTE.


Open in Gitpod

@jcommelin
Copy link
Member

I think all of these should also work for a linear_ordered_comm_group_with_zero. So that in the future they will also cover nnrat.
But I'm fine with merging this, and then we do a big generalization pass in the end, when Damiano's refactor is complete.

@jcommelin jcommelin requested a review from adomani May 25, 2021 12:07
@semorrison semorrison added the awaiting-review The author would like community review of the PR label May 25, 2021
@adomani
Copy link
Collaborator

adomani commented May 25, 2021

Dear Both,

I agree: these lemmas should be provable with more general assumptions. I might have just fixed the linarith issue with it, which means that I would be at the point where more of the group stuff has weaker hypotheses. The semiring/group_with_zero will be after that: there there is the further issue that multiplication is monotone only on the non-negative/positive elements, something that the current typeclasses are probably able to handle, but have not been tested yet.

The conclusion: I am happy to get this merged. After the refactor, it will be a festival of removing assumptions everywhere: I am only doing it in the most obvious places, with the most obvious weakenings.

@sgouezel
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 26, 2021
bors bot pushed a commit that referenced this pull request May 26, 2021
From LTE.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented May 26, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/nnreal): filling out some lemmas [Merged by Bors] - feat(data/nnreal): filling out some lemmas May 26, 2021
@bors bors bot closed this May 26, 2021
@bors bors bot deleted the nnreal_div branch May 26, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants