[Merged by Bors] - fix(tactic/induction): fix multiple cases'/induction' bugs #7717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLimperg
added
awaiting-review
Vierkantor
approved these changes
Jun 8, 2021
|
✌️ JLimperg can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
Thanks! Sorry for being too lazy to disentangle the various changes. bors r+ |
|
I wonder why Bors didn't notice your comment, maybe the Fastly outage? bors r+ |
github-actions
bot
added
ready-to-merge
|
bors r- |
|
✌️ JLimperg can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Canceled. |
bryangingechen
added
awaiting-author
* Fix generalisation in the presence of frozen local instances. Any time we revert a potentially frozen hypothesis, we now unfreeze local hypotheses during the operation. This makes sure that generalisation works uniformly whether or not any local instances are frozen. * Treat local defs as fixed during auto-generalisation induction' gets confused if we generalise over local definitions since they turn into lets when reverted. Ideally, we would handle local defs transparently, but that would require a lot of new code. So instead, we at least stop auto-generalisation from generalising them (and their dependencies). * Handle infinitely branching types induction' and cases' previously did not acknowledge the existence of infinitely branching types at all, leading to various internal errors. New test cases for all these bugs, due to Patrick Massot, were added to the test suite.
github-actions
bot
removed
the
merge-conflict
|
Thanks Anne for prodding Bors, and Sebastien for prodding me. bors r+ |
JLimperg
removed
the
awaiting-author
bors bot
pushed a commit
that referenced
this pull request
Jun 14, 2021
* Fix generalisation in the presence of frozen local instances. Any time we revert a potentially frozen hypothesis, we now unfreeze local hypotheses during the operation. This makes sure that generalisation works uniformly whether or not any local instances are frozen. * Treat local defs as fixed during auto-generalisation induction' gets confused if we generalise over local definitions since they turn into lets when reverted. Ideally, we would handle local defs transparently, but that would require a lot of new code. So instead, we at least stop auto-generalisation from generalising them (and their dependencies). * Handle infinitely branching types induction' and cases' previously did not acknowledge the existence of infinitely branching types at all, leading to various internal errors. New test cases for all these bugs, due to Patrick Massot, were added to the test suite.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix generalisation in the presence of frozen local instances.
Any time we revert a potentially frozen hypothesis, we now unfreeze local
hypotheses during the operation. This makes sure that generalisation works
uniformly whether or not any local instances are frozen.
Treat local defs as fixed during auto-generalisation
induction' gets confused if we generalise over local definitions since they
turn into lets when reverted. Ideally, we would handle local defs
transparently, but that would require a lot of new code. So instead, we at
least stop auto-generalisation from generalising them (and their
dependencies).
Handle infinitely branching types
induction' and cases' previously did not acknowledge the existence of
infinitely branching types at all, leading to various internal errors.
New test cases for all these bugs, due to Patrick Massot, were added to the test
suite.