New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(topology): continuous sections of a vector bundle are a vector space #7803
base: master
Are you sure you want to change the base?
Conversation
@sgouezel sorry why did you change the labels? |
Because you have made some suggestions on github but you haven't committed them, so I thought you were still updating the PR. It doesn't make sense for us to start reviewing if you are still changing the PR. |
Oh I just realized while reading the diff page that I left some typos in the docs, and I registered them as suggestions because I thought I could commit them together with the next easy suggestions that you or other maintainers will make, but if you prefer I can commit my corrections before |
Yes, please do commit them: it means that there are less discussions open, so we can focus on the interesting ones, and also when we look at the files we won't be disturbed by the typos. |
Done |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This PR/issue depends on: |
Can you merge master and fix the build? |
Lean is weirdly not letting me open the namespace |
I think, with this PR, the time has come to make a |
Should we make a folder |
I believe most of this PR has been added to master meanwhile. The only thing I couldn't see is the part about sections. (Merged master and left these parts about sections in for reference). I don't know much, should this be closed, or is that part about sections something you would want to add still? |
The main idea behind this PR is to implement sections both as bundled right inverses and as dependent type functions, and profit of the benefits of both.
Let
E : B → Type*
be the collection of fibers of a bundle onB
. In the case of sections of bundle we prove that the type of right inverses ofbundle.proj E
is equivalent to the typeΠ x : B, E x
. Both implementations of sections have their advantages:right_inv (proj E)
is better to talk about properties such as continuity, whereasΠ x : B, E x
works better with algebraic structures, it naturally inherits the algebraic structures present on the fibers, thanks to theΠ
instances. It is hence a good idea to implement both and write down the equivalence between them, but then we have to choose only one for our final implementation of sections.I believe this PR is important to show that the previously given implementation of vector bundles is natural and works well.