Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(topology): continuous sections of a vector bundle are a vector space #7803

Open
wants to merge 61 commits into
base: master
Choose a base branch
from

Conversation

Nicknamen
Copy link
Collaborator

@Nicknamen Nicknamen commented Jun 2, 2021

The main idea behind this PR is to implement sections both as bundled right inverses and as dependent type functions, and profit of the benefits of both.

Let E : B → Type* be the collection of fibers of a bundle on B. In the case of sections of bundle we prove that the type of right inverses of bundle.proj E is equivalent to the type Π x : B, E x. Both implementations of sections have their advantages:
right_inv (proj E) is better to talk about properties such as continuity, whereas Π x : B, E x works better with algebraic structures, it naturally inherits the algebraic structures present on the fibers, thanks to the Π instances. It is hence a good idea to implement both and write down the equivalence between them, but then we have to choose only one for our final implementation of sections.

I believe this PR is important to show that the previously given implementation of vector bundles is natural and works well.


Open in Gitpod

src/data/right_inv.lean Outdated Show resolved Hide resolved
@Nicknamen Nicknamen added the awaiting-review The author would like community review of the PR label Jun 2, 2021
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 2, 2021
@Nicknamen
Copy link
Collaborator Author

@sgouezel sorry why did you change the labels?

@Nicknamen Nicknamen added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 2, 2021
@sgouezel
Copy link
Collaborator

sgouezel commented Jun 2, 2021

Because you have made some suggestions on github but you haven't committed them, so I thought you were still updating the PR. It doesn't make sense for us to start reviewing if you are still changing the PR.

@Nicknamen
Copy link
Collaborator Author

Oh I just realized while reading the diff page that I left some typos in the docs, and I registered them as suggestions because I thought I could commit them together with the next easy suggestions that you or other maintainers will make, but if you prefer I can commit my corrections before

@sgouezel
Copy link
Collaborator

sgouezel commented Jun 2, 2021

Yes, please do commit them: it means that there are less discussions open, so we can focus on the interesting ones, and also when we look at the files we won't be disturbed by the typos.

src/data/right_inv.lean Outdated Show resolved Hide resolved
src/data/right_inv.lean Outdated Show resolved Hide resolved
src/data/right_inv.lean Outdated Show resolved Hide resolved
@Nicknamen
Copy link
Collaborator Author

Done

src/data/bundle.lean Outdated Show resolved Hide resolved
src/data/right_inv.lean Outdated Show resolved Hide resolved
src/data/right_inv.lean Outdated Show resolved Hide resolved
src/topology/vector_bundle.lean Outdated Show resolved Hide resolved
src/data/bundle.lean Outdated Show resolved Hide resolved
src/data/right_inv.lean Outdated Show resolved Hide resolved
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 5, 2022
@leanprover-community leanprover-community deleted a comment from github-actions bot Apr 5, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 5, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 5, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 6, 2022
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 6, 2022
@sgouezel
Copy link
Collaborator

sgouezel commented Apr 6, 2022

Can you merge master and fix the build?

@Nicknamen
Copy link
Collaborator Author

Lean is weirdly not letting me open the namespace trivialization... but apart from that things work smoothly

@Nicknamen Nicknamen added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 12, 2022
@hrmacbeth
Copy link
Member

I think, with this PR, the time has come to make a topology/vector_bundle/ folder. Could you do that with this PR, putting your material in a new file, and maybe also splitting out the direct sum construction?

@Nicknamen
Copy link
Collaborator Author

Should we make a folder bundle where to put also fiber bundles and, in the future, principal bundles? Or just a folder for vector bundles?

@fpvandoorn fpvandoorn added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jun 1, 2022
@joneugster
Copy link
Collaborator

I believe most of this PR has been added to master meanwhile. The only thing I couldn't see is the part about sections. (Merged master and left these parts about sections in for reference). I don't know much, should this be closed, or is that part about sections something you would want to add still?

@joneugster joneugster added WIP Work in progress awaiting-author A reviewer has asked the author a question or requested changes t-topology Topological spaces, uniform spaces, metric spaces, filters and removed awaiting-review The author would like community review of the PR merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Sep 10, 2022
@semorrison semorrison added the too-late This PR was ready too late for inclusion in mathlib3 label Jul 16, 2023
@semorrison semorrison removed their request for review August 6, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes t-topology Topological spaces, uniform spaces, metric spaces, filters too-late This PR was ready too late for inclusion in mathlib3 WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants