Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(mv_polynomial/equiv): speed up elaboration by adjusting priorities #7840

Closed
wants to merge 3 commits into from

Conversation

sgouezel
Copy link
Collaborator

@sgouezel sgouezel commented Jun 8, 2021

option_equiv_left timed out several times in bors, since the introduction of non-unital rings. We fix this by adjusting the priority to make sure that the problematic instance is found right away.

Also speed up circumcenter file (which also just timed out in bors) by squeezing simps.

@sgouezel sgouezel added the awaiting-review The author would like community review of the PR label Jun 8, 2021
@bors
Copy link

bors bot commented Jun 8, 2021

✌️ sgouezel can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 8, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@sgouezel
Copy link
Collaborator Author

sgouezel commented Jun 8, 2021

bors r+ p=37

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jun 8, 2021
bors bot pushed a commit that referenced this pull request Jun 8, 2021
…ies (#7840)

`option_equiv_left` timed out several times in bors, since the introduction of non-unital rings. We fix this by adjusting the priority to make sure that the problematic instance is found right away.

Also speed up circumcenter file (which also just timed out in bors) by squeezing simps.
@bors
Copy link

bors bot commented Jun 8, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(mv_polynomial/equiv): speed up elaboration by adjusting priorities [Merged by Bors] - chore(mv_polynomial/equiv): speed up elaboration by adjusting priorities Jun 8, 2021
@bors bors bot closed this Jun 8, 2021
@bors bors bot deleted the speed_up_equiv branch June 8, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants