Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/real/ennreal): add a algebra ℝ≥0 ℝ≥0∞ instance #7846

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(data/real/ennreal): add a algebra ℝ≥0 ℝ≥0∞ instance #7846

wants to merge 3 commits into from

Conversation

eric-wieser
Copy link
Member

Open in Gitpod

@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Jun 8, 2021
sgouezel
sgouezel reviewed Jun 10, 2021
View reviewed changes
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

src/data/real/ennreal.lean Outdated Show resolved Hide resolved
src/data/real/nnreal.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jun 10, 2021

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 10, 2021
@eric-wieser @sgouezel
Apply suggestions from code review
14e6727 
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@eric-wieser
Copy link
Member Author

Careless of me, thanks for catching that.

@bryangingechen
Copy link
Collaborator

@eric-wieser is this still ready to go?

@eric-wieser
Copy link
Member Author

bors r+

I was waiting for CI and forgot

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jun 18, 2021
bors bot pushed a commit that referenced this pull request Jun 18, 2021
@eric-wieser
feat(data/real/ennreal): add a algebra ℝ≥0 ℝ≥0∞ instance (#7846)
3a0653c
@bors
Copy link

bors bot commented Jun 18, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/real/ennreal): add a algebra ℝ≥0 ℝ≥0∞ instance [Merged by Bors] - feat(data/real/ennreal): add a algebra ℝ≥0 ℝ≥0∞ instance Jun 18, 2021
@bors bors bot closed this Jun 18, 2021
@bors bors bot deleted the eric-wieser/nnreal_mul_actions2 branch June 18, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eric-wieser @bryangingechen @sgouezel