Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(number_theory/{fermat4, sum_four_squares, zsqrtd/basic}): simplify/rearrange proofs #7866

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - chore(number_theory/{fermat4, sum_four_squares, zsqrtd/basic}): simplify/rearrange proofs #7866

wants to merge 3 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Jun 10, 2021 •
edited
Loading

These are mostly cosmetic changes, simplifying a couple of proofs. I would have tagged it easy, but since there are three files changed, it may take just over 20'' to review!

The main motivation is to reduce the diff in the bigger PR #7645.

Open in Gitpod

@adomani adomani added the awaiting-review The author would like community review of the PR label Jun 10, 2021
@jcommelin jcommelin changed the title chore(number_theory/{ fermat4, sum_four_squares, zsqrtd/basic}): simplify/rearrange proofs chore(number_theory/{fermat4, sum_four_squares, zsqrtd/basic}): simplify/rearrange proofs Jun 10, 2021
jcommelin
jcommelin approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 10, 2021
bors bot pushed a commit that referenced this pull request Jun 10, 2021
@adomani
chore(number_theory/{fermat4, sum_four_squares, zsqrtd/basic}): simpl…
4da899c 
…ify/rearrange proofs (#7866)

These are mostly cosmetic changes, simplifying a couple of proofs.  I would have tagged it `easy`, but since there are three files changed, it may take just over 20'' to review!

The main motivation is to reduce the diff in the bigger PR #7645.
@bors
Copy link

bors bot commented Jun 10, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(number_theory/{fermat4, sum_four_squares, zsqrtd/basic}): simplify/rearrange proofs [Merged by Bors] - chore(number_theory/{fermat4, sum_four_squares, zsqrtd/basic}): simplify/rearrange proofs Jun 10, 2021
@bors bors bot closed this Jun 10, 2021
@bors bors bot deleted the adomani_simpler_proofs branch June 10, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adomani @jcommelin