Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(data/real/nnreal): avoid abusing inequalities in nnreals #7872

Closed
wants to merge 2 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Jun 10, 2021

I removed the use of @, so that all implicit arguments stay implicit.

The main motivation is to reduce the diff in the bigger PR #7645: by only having the explicit arguments, the same proof works, without having to fiddle around with underscores.


Open in Gitpod

@adomani adomani added the awaiting-review The author would like community review of the PR label Jun 10, 2021
@sgouezel
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 10, 2021
bors bot pushed a commit that referenced this pull request Jun 10, 2021
I removed the use of `@`, so that all implicit arguments stay implicit.

The main motivation is to reduce the diff in the bigger PR #7645: by only having the explicit arguments, the same proof works, without having to fiddle around with underscores.
@bors
Copy link

bors bot commented Jun 10, 2021

This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried.

bors bot pushed a commit that referenced this pull request Jun 10, 2021
I removed the use of `@`, so that all implicit arguments stay implicit.

The main motivation is to reduce the diff in the bigger PR #7645: by only having the explicit arguments, the same proof works, without having to fiddle around with underscores.
@bors
Copy link

bors bot commented Jun 11, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jun 11, 2021
I removed the use of `@`, so that all implicit arguments stay implicit.

The main motivation is to reduce the diff in the bigger PR #7645: by only having the explicit arguments, the same proof works, without having to fiddle around with underscores.
@bors
Copy link

bors bot commented Jun 11, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/real/nnreal): avoid abusing inequalities in nnreals [Merged by Bors] - chore(data/real/nnreal): avoid abusing inequalities in nnreals Jun 11, 2021
@bors bors bot closed this Jun 11, 2021
@bors bors bot deleted the adomani_remove_ats branch June 11, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants