Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - docs(set_theory/schroeder_bernstein): add module docstring #7900

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - docs(set_theory/schroeder_bernstein): add module docstring #7900

wants to merge 4 commits into from

Conversation

YaelDillies
Copy link
Collaborator

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR lintfix This PR only fixes linting errors labels Jun 11, 2021
ericrbg
ericrbg reviewed Jun 12, 2021
View reviewed changes
src/set_theory/schroeder_bernstein.lean Outdated Show resolved Hide resolved
src/set_theory/schroeder_bernstein.lean Show resolved Hide resolved
src/set_theory/schroeder_bernstein.lean Outdated Show resolved Hide resolved
@ericrbg
Copy link
Collaborator

ericrbg commented Jun 12, 2021

my other comment was silly; I should've read ahead in Wiki saying that SB → EM, so this is definitely nonconstructive

@PatrickMassot PatrickMassot added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 13, 2021
@PatrickMassot
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 13, 2021
@bors
Copy link

bors bot commented Jun 13, 2021

Canceled.

@YaelDillies
Copy link
Collaborator Author

Oh whoops, bad timing 😅

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Jun 13, 2021
@PatrickMassot
Copy link
Member

It's my mistake, I didn't notice the waiting review label wasn't back yet.

@PatrickMassot
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 13, 2021
bors bot pushed a commit that referenced this pull request Jun 13, 2021
@YaelDillies
docs(set_theory/schroeder_bernstein): add module docstring (#7900)
b324488
@bors
Copy link

bors bot commented Jun 14, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title docs(set_theory/schroeder_bernstein): add module docstring [Merged by Bors] - docs(set_theory/schroeder_bernstein): add module docstring Jun 14, 2021
@bors bors bot closed this Jun 14, 2021
@bors bors bot deleted the yael/schroedbern branch June 14, 2021 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickMassot PatrickMassot PatrickMassot left review comments

@ericrbg ericrbg ericrbg left review comments

Assignees
No one assigned
Labels
lintfix This PR only fixes linting errors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaelDillies @ericrbg @PatrickMassot