-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(analysis/normed_space/basic): add has_nnnorm #7986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardobrasca
added
the
awaiting-review
The author would like community review of the PR
label
Jun 18, 2021
riccardobrasca
commented
Jun 18, 2021
ericrbg
approved these changes
Jun 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although got to admit that simpa = simp + rfl
was weird to see
jcommelin
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Jun 23, 2021
bors bot
pushed a commit
that referenced
this pull request
Jun 23, 2021
We create here classes `has_nndist` and `has_nnnorm` that are variants of `has_dist` and `has_norm` taking values in `ℝ≥0`. Obvious instances are `pseudo_metric_space` and `semi_normed_group`. These are not used that much in mathlib, but for example `has_nnnorm` is quite convenient for LTE.
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(analysis/normed_space/basic): add has_nnnorm
[Merged by Bors] - feat(analysis/normed_space/basic): add has_nnnorm
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We create here classes
has_nndist
andhas_nnnorm
that are variants ofhas_dist
andhas_norm
taking values inℝ≥0
. Obvious instances arepseudo_metric_space
andsemi_normed_group
.These are not used that much in mathlib, but for example
has_nnnorm
is quite convenient for LTE.