Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/normed_space/basic): add has_nnnorm #7986

Closed
wants to merge 9 commits into from

Conversation

riccardobrasca
Copy link
Member

We create here classes has_nndist and has_nnnorm that are variants of has_dist and has_norm taking values in ℝ≥0. Obvious instances are pseudo_metric_space and semi_normed_group.

These are not used that much in mathlib, but for example has_nnnorm is quite convenient for LTE.


Open in Gitpod

@riccardobrasca riccardobrasca added the awaiting-review The author would like community review of the PR label Jun 18, 2021
Copy link
Collaborator

@ericrbg ericrbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although got to admit that simpa = simp + rfl was weird to see

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 23, 2021
bors bot pushed a commit that referenced this pull request Jun 23, 2021
We create here classes `has_nndist` and `has_nnnorm` that are variants of `has_dist` and `has_norm` taking values in `ℝ≥0`.  Obvious instances are `pseudo_metric_space` and `semi_normed_group`.


These are not used that much in mathlib, but for example `has_nnnorm` is quite convenient for LTE.
@bors
Copy link

bors bot commented Jun 23, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/normed_space/basic): add has_nnnorm [Merged by Bors] - feat(analysis/normed_space/basic): add has_nnnorm Jun 23, 2021
@bors bors bot closed this Jun 23, 2021
@bors bors bot deleted the has_nnnorm branch June 23, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants