Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/fin): some lemmas about casts #8049

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - feat(data/fin): some lemmas about casts #8049

wants to merge 12 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Jun 22, 2021 •
edited

From LTE.

Open in Gitpod

@ericrbg ericrbg added the awaiting-review The author would like community review of the PR label Jun 22, 2021
jcommelin
jcommelin reviewed Jun 23, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help

src/data/fin.lean Outdated Show resolved Hide resolved
src/data/fin.lean Outdated Show resolved Hide resolved
src/data/fin.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 23, 2021
ericrbg
ericrbg commented Jun 23, 2021
View reviewed changes
src/data/fin.lean Outdated Show resolved Hide resolved
@ericrbg @jcommelin
fixup bad simp-lemma
12a33a5 
Co-authored-by: Johan Commelin <johan@commelin.net>
@ericrbg ericrbg added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 23, 2021
@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 23, 2021
Vierkantor
Vierkantor reviewed Jun 23, 2021
View reviewed changes
src/data/fin.lean Outdated Show resolved Hide resolved
src/data/fin.lean Outdated Show resolved Hide resolved
src/data/fin.lean Outdated Show resolved Hide resolved
src/data/fin.lean Outdated Show resolved Hide resolved
ericrbg
ericrbg commented Jun 23, 2021
View reviewed changes
src/data/fin.lean Outdated Show resolved Hide resolved
ericrbg and others added 3 commits June 23, 2021 11:29
@ericrbg @Vierkantor
change implicitness
3392c3a 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@ericrbg @eric-wieser
improve cast_succ_eq_zero_iff proof
04da401 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@ericrbg @Vierkantor
Update src/data/fin.lean
e1b1772 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@ericrbg ericrbg added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 23, 2021
@ericrbg @Vierkantor
rename lemma
5fee680 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
jcommelin
jcommelin reviewed Jun 23, 2021
View reviewed changes
src/data/fin.lean Outdated Show resolved Hide resolved
@ericrbg @jcommelin
Update src/data/fin.lean
67f6ca6 
Co-authored-by: Johan Commelin <johan@commelin.net>
Vierkantor
Vierkantor approved these changes Jun 23, 2021
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from these two comments, it looks good to me, thank you! I'll let the other reviewers check if they have any other suggestions.

src/data/fin.lean Show resolved Hide resolved
src/data/fin.lean Outdated Show resolved Hide resolved
@ericrbg @Vierkantor
add default proof
5ef8708 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
eric-wieser
eric-wieser reviewed Jun 23, 2021
View reviewed changes
src/data/fin.lean Outdated Show resolved Hide resolved
eric-wieser
eric-wieser reviewed Jun 23, 2021
View reviewed changes
src/data/fin.lean Outdated Show resolved Hide resolved
eric-wieser
eric-wieser reviewed Jun 23, 2021
View reviewed changes
src/data/fin.lean Outdated Show resolved Hide resolved
jcommelin
jcommelin approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 24, 2021
bors bot pushed a commit that referenced this pull request Jun 24, 2021
@ericrbg
feat(data/fin): some lemmas about casts (#8049)
5653516 
From [LTE](https://github.com/leanprover-community/lean-liquid/blob/master/src/for_mathlib/fin.lean).



Co-authored-by: Eric <37984851+ericrbg@users.noreply.github.com>
@bors
Copy link

bors bot commented Jun 24, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/fin): some lemmas about casts [Merged by Bors] - feat(data/fin): some lemmas about casts Jun 24, 2021
@bors bors bot closed this Jun 24, 2021
@bors bors bot deleted the lte_fin branch June 24, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ericrbg @eric-wieser @Vierkantor @jcommelin