Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - doc(*): add bold in doc strings for named theorems i.e. **mean value theorem** #8182

Closed
wants to merge 29 commits into from
Closed

[Merged by Bors] - doc(*): add bold in doc strings for named theorems i.e. **mean value theorem** #8182

wants to merge 29 commits into from

Conversation

hmonroe
Copy link
Collaborator

@hmonroe hmonroe commented Jul 2, 2021 •
edited by bryangingechen
Loading

bryangingechen
bryangingechen reviewed Jul 2, 2021
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also open a PR to our website repo which adds a suggestion to bold names in this section: https://github.com/leanprover-community/leanprover-community.github.io/blob/newsite/templates/contribute/doc.md#doc-strings

src/algebra/ordered_group.lean Outdated Show resolved Hide resolved
@bryangingechen bryangingechen added the awaiting-author A reviewer has asked the author a question or requested changes label Jul 2, 2021
eric-wieser
eric-wieser reviewed Jul 3, 2021
View reviewed changes
src/data/nat/prime.lean Outdated Show resolved Hide resolved
@hmonroe @eric-wieser
Update src/data/nat/prime.lean
bb89612 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
bryangingechen
bryangingechen reviewed Jul 3, 2021
View reviewed changes
src/data/nat/prime.lean Show resolved Hide resolved
src/group_theory/sylow.lean Outdated Show resolved Hide resolved
src/number_theory/quadratic_reciprocity.lean Outdated Show resolved Hide resolved
src/number_theory/sum_four_squares.lean Outdated Show resolved Hide resolved
src/set_theory/cardinal.lean Outdated Show resolved Hide resolved
src/linear_algebra/matrix/nonsingular_inverse.lean Outdated Show resolved Hide resolved
src/data/nat/digits.lean Outdated Show resolved Hide resolved
hmonroe and others added 3 commits July 3, 2021 16:41
@hmonroe @hrmacbeth
Update src/number_theory/liouville/basic.lean
8a55d11 
Co-authored-by: hrmacbeth <25316162+hrmacbeth@users.noreply.github.com>
@hmonroe @hrmacbeth
Update src/analysis/p_series.lean
6526107 
Co-authored-by: hrmacbeth <25316162+hrmacbeth@users.noreply.github.com>
@hmonroe
doc(all): add bold for named theorems
8fcca3c
@hmonroe hmonroe added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 4, 2021
bryangingechen
bryangingechen reviewed Jul 5, 2021
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more things I noticed! Thanks for doing this by the way!

src/combinatorics/simple_graph/matching.lean Outdated Show resolved Hide resolved
src/number_theory/pell.lean Outdated Show resolved Hide resolved
src/number_theory/sum_two_squares.lean Outdated Show resolved Hide resolved
src/ring_theory/noetherian.lean Outdated Show resolved Hide resolved
hmonroe and others added 6 commits July 5, 2021 12:49
@hmonroe @bryangingechen
Update src/number_theory/pell.lean
391fd01 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@hmonroe @bryangingechen
Update src/number_theory/sum_two_squares.lean
ef8fe73 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@hmonroe @bryangingechen
Update src/ring_theory/noetherian.lean
b6ac3a9 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@hmonroe
doc(all): add bold for named theorems
853ce2c
@hmonroe
doc(all): add bold for named theorems
e4545ea
@hmonroe
doc(all): add bold for named theorems
34e9603
@Vierkantor Vierkantor mentioned this pull request Jul 6, 2021
Closed
Vierkantor added a commit that referenced this pull request Jul 6, 2021
@Vierkantor
Bold named theorems in docstrings, following #8182
a13e309
@bryangingechen
Copy link
Collaborator

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 6, 2021
bors bot pushed a commit that referenced this pull request Jul 6, 2021
@hmonroe
doc(*): add bold in doc strings for named theorems i.e. **mean value …
ec07293 
…theorem** (#8182)
@bors
Copy link

bors bot commented Jul 6, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title doc(*): add bold in doc strings for named theorems i.e. **mean value theorem** [Merged by Bors] - doc(*): add bold in doc strings for named theorems i.e. **mean value theorem** Jul 6, 2021
@bors bors bot closed this Jul 6, 2021
@bors bors bot deleted the named_theorems branch July 6, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@bryangingechen bryangingechen bryangingechen left review comments

@hrmacbeth hrmacbeth hrmacbeth left review comments

@ericrbg ericrbg ericrbg left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hmonroe @bryangingechen @eric-wieser @hrmacbeth @ericrbg