Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(*): standardize Prop/Type instance names #8360

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - chore(*): standardize Prop/Type instance names #8360

wants to merge 5 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Jul 18, 2021 •
edited by eric-wieser
Loading

autogenerated names for these instances mention sort. instead of Prop.

Open in Gitpod

@ericrbg ericrbg added RFC Request for comment awaiting-review The author would like community review of the PR labels Jul 18, 2021
eric-wieser
eric-wieser reviewed Jul 18, 2021
View reviewed changes
src/logic/basic.lean Outdated Show resolved Hide resolved
@eric-wieser
Copy link
Member

eric-wieser commented Jul 18, 2021 •
edited
Loading

I think the correct ideal fix here would be to adjust these lines:

https://github.com/leanprover-community/lean/blob/cd4973b96eecb4d6ba52e14cd67f6c4ad251b467/src/frontends/lean/decl_util.cpp#L134-L136

which could use a heuristic similar to

https://github.com/leanprover-community/lean/blob/65ad4ffdb3abac75be748554e3cbe990fb1c6500/src/frontends/lean/pp.cpp#L687-L699

and then use the auto-generated names. The crux of the problem is that Prop is just notation for Sort 0, and isn't being special cased here where it should be.

@ericrbg
Copy link
Collaborator Author

ericrbg commented Jul 18, 2021

Is it worth doing it now, and then removing this when the update goes to mathlib? Or just leave it as a todo for now? I'll take a look at fixing the code, though. One more thing; should we make it Prop. or prop.?

@ericrbg
Copy link
Collaborator Author

ericrbg commented Jul 18, 2021 •
edited
Loading

leanprover-community/lean#591

@ericrbg ericrbg changed the title chore(*): standardize Prop instance names chore(*): standardize Prop/Type instance names Jul 19, 2021
@eric-wieser
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 25, 2021
bors bot pushed a commit that referenced this pull request Jul 25, 2021
@ericrbg
chore(*): standardize Prop/Type instance names (#8360)
0c024a6 
autogenerated names for these instances mention `sort.` instead of `Prop.`



Co-authored-by: Eric <37984851+ericrbg@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 25, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(*): standardize Prop/Type instance names [Merged by Bors] - chore(*): standardize Prop/Type instance names Jul 25, 2021
@bors bors bot closed this Jul 25, 2021
@bors bors bot deleted the fixup_instances branch July 25, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) RFC Request for comment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ericrbg @eric-wieser