Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/equiv/mul_add): add equiv.(div,sub)_(left,right) #8385

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(data/equiv/mul_add): add equiv.(div,sub)_(left,right) #8385

wants to merge 5 commits into from

Conversation

eric-wieser
Copy link
Member

Open in Gitpod

@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Jul 26, 2021
@fpvandoorn
Copy link
Member

I don't mind merging this, but just curious, why is this useful? defeq is usually not that important.

@eric-wieser
Copy link
Member Author

This made a proof a little cleaner in this Zulip thread.

It's fairly common that you have a goal in terms of an unbundled function, and the way to prove it is to construct a bundled version of that function then invoke a lemma about equivs. If the bundled version isn't defeq, then sometimes you have to clean up the mess with convert

@fpvandoorn
Copy link
Member

Oh, that's fair.

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 2, 2021
bors bot pushed a commit that referenced this pull request Aug 2, 2021
@eric-wieser
feat(data/equiv/mul_add): add equiv.(div,sub)_(left,right) (#8385)
17b1e7c
@bors
Copy link

bors bot commented Aug 2, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/equiv/mul_add): add equiv.(div,sub)_(left,right) [Merged by Bors] - feat(data/equiv/mul_add): add equiv.(div,sub)_(left,right) Aug 2, 2021
@bors bors bot closed this Aug 2, 2021
@bors bors bot deleted the eric-wieser/equiv.sub_left branch August 2, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eric-wieser @fpvandoorn