refactor(analysis/normed_space/basic) Remove outparam in normed space #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 22, 2019
sgouezel
force-pushed
the
remove_outparam
branch
from
ebe375c
to
7e47cce
Compare
jcommelin
approved these changes
Mar 27, 2019
|
@jcommelin Thanks, this is helpful. It looks good to me, so I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still outparams in the definition of
normed_space, probably forgotten in the module refactor. A consequence is thatis_bounded_linear_mapsandhas_fderivhave been defined without mentioning explicitely the field of scalars. This makes it impossible to distinguish R-bounded linear maps and C-bounded linear maps on a complex vector space, or to distinguish between the real derivative and the complex derivative.We remove the outparam in the definition, and add the field of scalars where necessary.
This PR conflicts with virtually all my recent PRs, I guess, but I think this one should be merged first (and if possible rapidly, otherwise conflicts will show up again quickly) and then I will rebase the other PRs.