Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(topology/locally_constant/basic): coercion of locally-constant function to continuous map #8444

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat(topology/locally_constant/basic): coercion of locally-constant function to continuous map #8444

wants to merge 6 commits into from

Conversation

ocfnash
Copy link
Collaborator

@ocfnash ocfnash commented Jul 27, 2021

Open in Gitpod

@ocfnash ocfnash added the awaiting-review The author would like community review of the PR label Jul 27, 2021
jcommelin
jcommelin approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 27, 2021
@jcommelin
Copy link
Member

bors r-

@bors
Copy link

bors bot commented Jul 27, 2021

Canceled.

@bors
Copy link

bors bot commented Jul 27, 2021

✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

eric-wieser
eric-wieser approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Jul 27, 2021
ocfnash and others added 3 commits July 27, 2021 15:58
@ocfnash @eric-wieser
Update src/topology/locally_constant/basic.lean
01265ca 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@ocfnash @eric-wieser
Update src/topology/locally_constant/basic.lean
b88d73a 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@ocfnash @eric-wieser
Update src/topology/locally_constant/basic.lean
9838c08 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@ocfnash
Copy link
Collaborator Author

ocfnash commented Jul 27, 2021

bors merge

bors bot pushed a commit that referenced this pull request Jul 27, 2021
@ocfnash
feat(topology/locally_constant/basic): coercion of locally-constant f…
768980a 
…unction to continuous map (#8444)
@bors
Copy link

bors bot commented Jul 27, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/locally_constant/basic): coercion of locally-constant function to continuous map [Merged by Bors] - feat(topology/locally_constant/basic): coercion of locally-constant function to continuous map Jul 27, 2021
@bors bors bot closed this Jul 27, 2021
@bors bors bot deleted the locally_constant_continuous branch July 27, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@eric-wieser eric-wieser eric-wieser approved these changes

@kbuzzard kbuzzard Awaiting requested review from kbuzzard

@laughinggas laughinggas Awaiting requested review from laughinggas

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ocfnash @jcommelin @eric-wieser