Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(algebra/group/hom_instances): add monoid_hom versions of linear_map lemmas #8461

Closed
wants to merge 4 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jul 29, 2021

I mainly want the additive versions, but we may as well get the multiplicative ones too.

This also adds the missing monoid_hom.map_div and some other division versions of subtraction lemmas.


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Jul 29, 2021
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 29, 2021
eric-wieser and others added 2 commits July 29, 2021 21:35
Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
@eric-wieser eric-wieser changed the title chore(algebra/group/hom_instance): add monoid_hom versions of linear_map lemmas chore(algebra/group/hom_instances): add monoid_hom versions of linear_map lemmas Jul 29, 2021
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 29, 2021
@PatrickMassot
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 1, 2021
bors bot pushed a commit that referenced this pull request Aug 1, 2021
…_map lemmas (#8461)

I mainly want the additive versions, but we may as well get the multiplicative ones too.

This also adds the missing `monoid_hom.map_div` and some other division versions of subtraction lemmas.
@bors
Copy link

bors bot commented Aug 1, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/group/hom_instances): add monoid_hom versions of linear_map lemmas [Merged by Bors] - chore(algebra/group/hom_instances): add monoid_hom versions of linear_map lemmas Aug 1, 2021
@bors bors bot closed this Aug 1, 2021
@bors bors bot deleted the eric-wieser/map_add2 branch August 1, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants