[Merged by Bors] - feat(topology/discrete_quotient): add two lemmas #8464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faenuccio
added
the
awaiting-review
eric-wieser
reviewed
Jul 29, 2021
eric-wieser
approved these changes
Jul 29, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
adamtopaz
reviewed
Jul 29, 2021
eric-wieser
reviewed
Jul 30, 2021
eric-wieser
reviewed
Jul 30, 2021
PatrickMassot
added
awaiting-author
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
faenuccio
added
awaiting-review
eric-wieser
reviewed
Aug 3, 2021
adamtopaz
reviewed
Aug 3, 2021
src/topology/discrete_quotient.lean
Outdated
Comment on lines
207
to
208
| @[simp] lemma is_clopen_discrete [discrete_topology X] (x : set X) : is_clopen x := | ||
| ⟨is_open_discrete _, is_closed_discrete _⟩ |
There was a problem hiding this comment.
This lemma should go after is_closed_discrete in topology/order.lean.
There was a problem hiding this comment.
Ok, thanks, I'll move it.
There was a problem hiding this comment.
I don't know if is_clopen is available yet there...
There was a problem hiding this comment.
Eric is probably right... If this is the case, I guess this lemma could go near where is_clopen is defined.
There was a problem hiding this comment.
Should I put it in topology/subset_properties.lean alongside other properties of clopen sets?
There was a problem hiding this comment.
Yes, I think that's a reasonable place for it.
adamtopaz
reviewed
Aug 3, 2021
|
Looks good to me. I'll activate bors once the CI is happy. |
Co-authored-by: Adam Topaz <adamtopaz@users.noreply.github.com>
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 3, 2021
Add lemmas `proj_bot_injective` and `proj_bot_bijective`, the former needed for the latter, and the latter needed in LTE. Co-authored-by: Filippo A. E. Nuccio <65080144+faenuccio@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lemmas
proj_bot_injectiveandproj_bot_bijective, the former needed for the latter, and the latter needed in LTE.