Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(group_theory/group_action/subgroup): Conjugation action on subgroups of a group #8592

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Aug 9, 2021
@ChrisHughes24 ChrisHughes24 changed the title Conj subgroup action feat(group_theory/group_action/subgroup): Conjugation action on subgroups of a group Aug 9, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 9, 2021
@github-actions github-actions bot removed merge-conflict Please `git merge origin/master` then a bot will remove this label. blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Aug 9, 2021
@ChrisHughes24 ChrisHughes24 added the awaiting-review The author would like community review of the PR label Aug 9, 2021
variables {G : Type*} [group G]

/-- The conjugation action of `G` on the subgroups of `G` -/
instance subgroup.mul_action' : mul_action G (subgroup G) :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the '? Is there another subgroup.mul_action? If so, should this one be a global instance?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other one is presumably (S : subgroup G) [mul_action G M] : mul_action S M which is just a naming conflict, not a semantic one.

@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 12, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 12, 2021
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 13, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Aug 15, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 25, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 15, 2021
@ChrisHughes24
Copy link
Member Author

It doesn't really make much sense to define this action in terms of the conjugation action of groups on themselves since I had to make a type alias to define that action, but there's no need for a type alias here because there are no other actions that you might want to define.

@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Sep 15, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Sep 16, 2021
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 6, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 13, 2021
@github-actions github-actions bot added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label Apr 20, 2023
@YaelDillies YaelDillies added t-algebra Algebra (groups, rings, fields etc) and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Apr 20, 2023
@YaelDillies
Copy link
Collaborator

YaelDillies commented Apr 20, 2023

From what I gather, this action now exists as mul_action (mul_aut G) (subgroup G) instead of mul_action G (subgroup G) as offers this PR. @eric-wieser, is there a case for introducing this new action, or should we migrate the few exclusive lemmas from this PR to the mul_aut action?

@eric-wieser
Copy link
Member

From what I gather, this action now exists as mul_action (mul_aut G) (subgroup G) instead of mul_action G (subgroup G) as offers this PR.

Correct

@eric-wieser, is there a case for introducing this new action, or should we migrate the few exclusive lemmas from this PR to the mul_aut action?

I don't like the idea of the mul_action G (subgroup G). mul_action (conj_act G) (subgroup G) ought to be safe though; it's entirely possible that instance can already be found by lean.

@ChrisHughes24
Copy link
Member Author

From what I gather, this action now exists as mul_action (mul_aut G) (subgroup G) instead of mul_action G (subgroup G) as offers this PR. @eric-wieser, is there a case for introducing this new action, or should we migrate the few exclusive lemmas from this PR to the mul_aut action?

I think there is a need for this action, because mul_aut G is a different group with a different cardinality, so you won't be able to apply the orbit-stablizer theorem in the same way for example.

@YaelDillies
Copy link
Collaborator

The action in this PR isn't mul_action (mul_aut G) (subgroup G) but mul_action (conj_act G) (subgroup G), and conj_act G is the same group as G. The only downside so far is that the statement of stabilizer_eq_normalizer became more complicated, because you need to insert a map to_conj_act in there.

Somewhat relatingly, do we want a typeclass for an action to be a conjugation action? Of course G acts on subgroup G by conjugation, but so does any subgroup of G, and that isn't currently covered by this PR.

@ChrisHughes24
Copy link
Member Author

I think it is covered by some instance saying if G acts on X so does any subgroup of G

@YaelDillies
Copy link
Collaborator

Yes, but some lemmas in this PR are about g • H where g : conj_act G and H : subgroup G, and they should still hold true if instead g : conj_act G' where G' : subgroup G.

@semorrison semorrison added the too-late This PR was ready too late for inclusion in mathlib3 label Jul 16, 2023
@ChrisHughes24 ChrisHughes24 reopened this Aug 18, 2023
@YaelDillies
Copy link
Collaborator

Sorry, why was this marked too-late? It compiled by the cutoff date. If it's because it's marked awaiting-author, let me mark it awaiting-review, since there are interesting lemmas to be saved.

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 and removed awaiting-author A reviewer has asked the author a question or requested changes too-late This PR was ready too late for inclusion in mathlib3 labels Aug 31, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lemmas added to other files are hopefully uncontroversial. For the ones in this file, I would like someone else's opinion. Maybe @eric-wieser?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review The author would like community review of the PR modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants