New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(group_theory/group_action/subgroup): Conjugation action on subgroups of a group #8592
base: master
Are you sure you want to change the base?
Conversation
ChrisHughes24
commented
Aug 9, 2021
•
edited by github-actions
bot
edited by github-actions
bot
- depends on: [Merged by Bors] - feat(group_theory/subgroup): lemmas relating normalizer and map and comap #8458
- depends on: [Merged by Bors] - feat(group_theory/group_action/conj_act): conjugation action of groups #8627
variables {G : Type*} [group G] | ||
|
||
/-- The conjugation action of `G` on the subgroups of `G` -/ | ||
instance subgroup.mul_action' : mul_action G (subgroup G) := |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the '
? Is there another subgroup.mul_action
? If so, should this one be a global instance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other one is presumably (S : subgroup G) [mul_action G M] : mul_action S M
which is just a naming conflict, not a semantic one.
It doesn't really make much sense to define this action in terms of the conjugation action of groups on themselves since I had to make a type alias to define that action, but there's no need for a type alias here because there are no other actions that you might want to define. |
…community/mathlib into conj_subgroup_action
From what I gather, this action now exists as |
Correct
I don't like the idea of the |
I think there is a need for this action, because |
The action in this PR isn't Somewhat relatingly, do we want a typeclass for an action to be a conjugation action? Of course |
I think it is covered by some instance saying if G acts on X so does any subgroup of G |
Yes, but some lemmas in this PR are about |
Sorry, why was this marked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lemmas added to other files are hopefully uncontroversial. For the ones in this file, I would like someone else's opinion. Maybe @eric-wieser?