[Merged by Bors] - feat(tactic/abel): check for defeq of atoms instead of syntactic eq #8628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still need to figure out what the default reducibility of `is_def_eq` will be here, or whether this will make calls to `abel` significantly slower. The level of reducibility should probably be a parameter to the tactic.
Vierkantor
added
WIP
Use `abel!` for trying to unify up to `semireducible`. Also renamed the `tactic.abel.cache` to `tactic.abel.context`, since we store more things in there than a few elaborated terms.
I'll just do the ones that the linter complains about for now, and let someone with more understanding of what `abel` does underneath the hood explain the rest.
Vierkantor
added
awaiting-review
robertylewis
approved these changes
Aug 13, 2021
|
✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2021
…8628) I had a call to `abel` break after adding a new typeclass instance, and it turns out this was because two terms became defeq-but-not-syntactically-eq. This PR modifies the equality check in `abel` to follow the implementation in e.g. `ring`. By default, `abel` now unifies atoms up to `reducible`, which should not have a huge impact on build times. Use `abel!` for trying to unify up to `semireducible`. I also renamed the `tactic.abel.cache` to `tactic.abel.context`, since we store more things in there than a few elaborated terms. To appease the docstring linter, I added docs for all of the renamed `def`s. Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
github-actions
bot
added
the
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
digama0
added
the
modifies-tactic-syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a call to
abelbreak after adding a new typeclass instance, and it turns out this was because two terms became defeq-but-not-syntactically-eq. This PR modifies the equality check inabelto follow the implementation in e.g.ring.By default,
abelnow unifies atoms up toreducible, which should not have a huge impact on build times. Useabel!for trying to unify up tosemireducible.I also renamed the
tactic.abel.cachetotactic.abel.context, since we store more things in there than a few elaborated terms. To appease the docstring linter, I added docs for all of the renameddefs.