Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/basic, group_theory/quotient_group, algebra/lie/quotient): ext lemmas for morphisms out of quotients #8641

Closed
wants to merge 6 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Aug 12, 2021

This allows ext to see through quotients by subobjects of a type A, and apply ext lemmas specific to A.


Open in Gitpod

@eric-wieser eric-wieser changed the title feat(linear_algebra/basic, group_theory/quotient_group): Ext lemmas for quotients feat(linear_algebra/basic, group_theory/quotient_group, algebra/lie/quotient): ext lemmas for morphisms out of quotients Aug 12, 2021
@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Aug 12, 2021
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, the proofs clean up noticeably!

@ocfnash, could you check the Lie algebra parts?

@eric-wieser
Copy link
Member Author

(in case you missed it @Vierkantor, Oliver commented at #8641 (comment) already)

Copy link
Collaborator

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Vierkantor
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 13, 2021
bors bot pushed a commit that referenced this pull request Aug 13, 2021
…uotient): ext lemmas for morphisms out of quotients (#8641)

This allows `ext` to see through quotients by subobjects of a type `A`, and apply ext lemmas specific to `A`.
@bors
Copy link

bors bot commented Aug 13, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 13, 2021
…uotient): ext lemmas for morphisms out of quotients (#8641)

This allows `ext` to see through quotients by subobjects of a type `A`, and apply ext lemmas specific to `A`.
@bors
Copy link

bors bot commented Aug 13, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/basic, group_theory/quotient_group, algebra/lie/quotient): ext lemmas for morphisms out of quotients [Merged by Bors] - feat(linear_algebra/basic, group_theory/quotient_group, algebra/lie/quotient): ext lemmas for morphisms out of quotients Aug 13, 2021
@bors bors bot closed this Aug 13, 2021
@bors bors bot deleted the eric-wieser/quotient.ext branch August 13, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants