Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(tactic/lint): add universe linter #8685

Closed
wants to merge 7 commits into from

Conversation

fpvandoorn
Copy link
Member

@fpvandoorn fpvandoorn commented Aug 15, 2021

  • The linter checks that there are no bad max u v occurrences in declarations (bad means that neither u nor v occur by themselves). See documentation for more details.
  • meta/expr now imports meta/rb_map (but this doesn't give any new transitive imports, so it barely matters). I also removed a transitive import from meta/rb_map.

Open in Gitpod

@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Aug 15, 2021
@fpvandoorn fpvandoorn added t-meta Tactics, attributes or user commands awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Aug 15, 2021
src/meta/expr.lean Outdated Show resolved Hide resolved
Floris van Doorn and others added 2 commits August 15, 2021 11:45
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Aug 16, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@robertylewis
Copy link
Member

Nice!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 17, 2021
bors bot pushed a commit that referenced this pull request Aug 17, 2021
* The linter checks that there are no bad `max u v` occurrences in declarations (bad means that neither `u` nor `v` occur by themselves). See documentation for more details.
* `meta/expr` now imports `meta/rb_map` (but this doesn't give any new transitive imports, so it barely matters). I also removed a transitive import from `meta/rb_map`.



Co-authored-by: Floris van Doorn <fpv@andrew.cmu.edu>
@bors
Copy link

bors bot commented Aug 17, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(tactic/lint): add universe linter [Merged by Bors] - feat(tactic/lint): add universe linter Aug 17, 2021
@bors bors bot closed this Aug 17, 2021
@bors bors bot deleted the lint-max-univ branch August 17, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants