feat(tactic/lint/simp): simp_var_head uses whnf reducible
#8749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpvandoorn
added
awaiting-review
|
This is just wrong for Lean 3, the simplifier doesn't unfold anything: example : true := by trace_simp_set only [my_eq_on_empty]
/-
simplification rules for iff
[my_eq_on_empty] #4, my_eq_on ?x_2 ?x_3 ∅ ↦ true
-/Not sure if it's worth to add a linter just for the port. |
|
Ah, I see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
simp_var_headlinter so that it unfolds reducible definitions.@gebner Do we also want this for the other simp linters? I'm not sure, so I currently kept their behavior as before.
Related Zulip: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/bad.20simp.20lemmas