Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix(algebra/ordered_monoid): slay with_top monoid diamonds caused by irreducibility #8926

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - fix(algebra/ordered_monoid): slay with_top monoid diamonds caused by irreducibility #8926

wants to merge 7 commits into from

Conversation

pechersky
Copy link
Collaborator

@pechersky pechersky commented Aug 30, 2021 •
edited

https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/Diamond.20in.20instances.20on.20.60with_top.20R.60

Instead of copying over from with_zero, just work through the definitions directly.

Open in Gitpod

@pechersky pechersky added the awaiting-review The author would like community review of the PR label Aug 30, 2021
@eric-wieser eric-wieser changed the title fix(algebra/ordered_monoid): slay with_top monoid diamonds fix(algebra/ordered_monoid): slay with_top monoid diamonds caused by irreducibility Aug 31, 2021
sgouezel
sgouezel reviewed Aug 31, 2021
View reviewed changes
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove Line 792 local attribute [semireducible] with_zero in algebra/ordered_monoid.lean, I don't think it is useful any more. Same thing on Line 114 of data/polynomial/ring_division.lean.

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 31, 2021
@pechersky pechersky added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 31, 2021
@sgouezel
Copy link
Collaborator

sgouezel commented Sep 4, 2021

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 4, 2021
bors bot pushed a commit that referenced this pull request Sep 4, 2021
@pechersky
fix(algebra/ordered_monoid): slay with_top monoid diamonds caused by …
2ea1650 
…irreducibility (#8926)

https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/Diamond.20in.20instances.20on.20.60with_top.20R.60

Instead of copying over from `with_zero`, just work through the definitions directly.
@bors
Copy link

bors bot commented Sep 4, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(algebra/ordered_monoid): slay with_top monoid diamonds caused by irreducibility [Merged by Bors] - fix(algebra/ordered_monoid): slay with_top monoid diamonds caused by irreducibility Sep 4, 2021
@bors bors bot closed this Sep 4, 2021
@bors bors bot deleted the pechersky/with-top-monoid-diamond branch September 4, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@sgouezel sgouezel sgouezel left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pechersky @sgouezel @eric-wieser