Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(linear_algebra/affine_space/independent): allow dot notation on affine_independent #8974

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - chore(linear_algebra/affine_space/independent): allow dot notation on affine_independent #8974

wants to merge 4 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Sep 3, 2021 •
edited by github-actions bot

This renames a few lemmas to make dot notation on affine_independent possible.

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Sep 3, 2021
@YaelDillies YaelDillies mentioned this pull request Sep 5, 2021
Closed
2 tasks
Vierkantor
Vierkantor approved these changes Sep 6, 2021
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 6, 2021
bors bot pushed a commit that referenced this pull request Sep 6, 2021
@YaelDillies
chore(linear_algebra/affine_space/independent): allow dot notation on…
3ca5b69 
… affine_independent (#8974)

This renames a few lemmas to make dot notation on `affine_independent` possible.
@bors
Copy link

bors bot commented Sep 6, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 6, 2021
@YaelDillies
chore(linear_algebra/affine_space/independent): allow dot notation on…
97243da 
… affine_independent (#8974)

This renames a few lemmas to make dot notation on `affine_independent` possible.
@bors
Copy link

bors bot commented Sep 6, 2021

Build failed (retrying...):

@bryangingechen
Copy link
Collaborator

bors r-

@bors
Copy link

bors bot commented Sep 6, 2021

Canceled.

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Sep 6, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Sep 6, 2021
@bryangingechen
Copy link
Collaborator

bryangingechen commented Sep 6, 2021 •
edited

Per Zulip, please wait for #8892 to be merged and then merge master into this PR and put back on the queue. Thanks!
bors d+

@bors
Copy link

bors bot commented Sep 6, 2021

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Sep 7, 2021
@github-actions
Copy link

github-actions bot commented Sep 7, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 8, 2021
@YaelDillies
chore(linear_algebra/affine_space/independent): allow dot notation on…
3d31c2d 
… affine_independent (#8974)

This renames a few lemmas to make dot notation on `affine_independent` possible.
@bors
Copy link

bors bot commented Sep 8, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(linear_algebra/affine_space/independent): allow dot notation on affine_independent [Merged by Bors] - chore(linear_algebra/affine_space/independent): allow dot notation on affine_independent Sep 8, 2021
@bors bors bot closed this Sep 8, 2021
@bors bors bot deleted the affine_indep branch September 8, 2021 16:06
@YaelDillies YaelDillies removed the awaiting-author A reviewer has asked the author a question or requested changes label Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaelDillies @bryangingechen @Vierkantor