[Merged by Bors] - feat(ring_theory/henselian): Henselian local rings #8986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jcommelin
commented
Sep 3, 2021
•
jcommelin
commented
- depends on: [Merged by Bors] - feat(ring_theory/ideal/operations): ring_hom.ker_is_maximal_of_surjective #8990
- depends on: [Merged by Bors] - feat(ring_theory/ideal/local_ring): residue field is an algebra #8991
- depends on: [Merged by Bors] - feat(linear_algebra/smodeq): sub_mem, eval #8993
- depends on: [Merged by Bors] - feat(ring_theory/ideal/operations): ideal.pow_mem_pow #8996
- depends on: [Merged by Bors] - feat(data/polynomial/taylor): Taylor expansion of polynomials #9000
- depends on: [Merged by Bors] - feat(linear_algebra/adic_completion): le_jacobson_bot #9125
Also, the kernel of a surjective map to a field is equal to the unique maximal ideal.
…l coefficients I place this identity in a new file because the current proof depends on `polynomial`.
github-actions
bot
added
blocked-by-other-PR
|
🎉 Great news! Looks like all the dependencies have been resolved:
💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
github-actions
bot
removed
the
merge-conflict
eric-wieser
reviewed
Sep 16, 2021
adamtopaz
approved these changes
Sep 19, 2021
There was a problem hiding this comment.
LGTM!
I'll let @eric-wieser see if he's happy with the unit stuff before merging.
|
|
||
| open local_ring polynomial function | ||
|
|
||
| lemma is_local_ring_hom_of_le_jacobson_bot {R : Type*} [comm_ring R] |
There was a problem hiding this comment.
An argument can be made that this should go in ring_theory.jacobson_ideal, but is_local_ring_hom isn't imported there. I don't mind either way, to be honest.
There was a problem hiding this comment.
I agree. At some point it will move to a proper home.
eric-wieser
reviewed
Sep 20, 2021
eric-wieser
reviewed
Sep 20, 2021
kbuzzard
approved these changes
Sep 28, 2021
|
bors r+ |
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.