Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix(category_theory/concrete_category): remove bad instance #9154

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - fix(category_theory/concrete_category): remove bad instance #9154

wants to merge 3 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented Sep 12, 2021 •
edited

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Sep 12, 2021
@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 12, 2021
bors bot pushed a commit that referenced this pull request Sep 12, 2021
@semorrison
fix(category_theory/concrete_category): remove bad instance (#9154)
32e9e45 
Per @fpvandoorn's [new linter](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/type-class.20loops.20in.20category.20theory).
@bors
Copy link

bors bot commented Sep 12, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 12, 2021
@semorrison
fix(category_theory/concrete_category): remove bad instance (#9154)
0c40029 
Per @fpvandoorn's [new linter](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/type-class.20loops.20in.20category.20theory).
@bryangingechen
Copy link
Collaborator

Linting failed.
bors r-

@bors
Copy link

bors bot commented Sep 12, 2021

Canceled.

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Sep 12, 2021
@bryangingechen
Copy link
Collaborator

bors d+

@bors
Copy link

bors bot commented Sep 12, 2021

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison
Copy link
Collaborator Author

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 12, 2021
bors bot pushed a commit that referenced this pull request Sep 12, 2021
@semorrison
fix(category_theory/concrete_category): remove bad instance (#9154)
f863703 
Per @fpvandoorn's [new linter](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/type-class.20loops.20in.20category.20theory).
@bors
Copy link

bors bot commented Sep 12, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(category_theory/concrete_category): remove bad instance [Merged by Bors] - fix(category_theory/concrete_category): remove bad instance Sep 12, 2021
@bors bors bot closed this Sep 12, 2021
@bors bors bot deleted the reflects_isomorphisms_forget2 branch September 12, 2021 08:06
@fpvandoorn
Copy link
Member

Oops, my bad for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@semorrison @fpvandoorn @bryangingechen