Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(category/abelian/pseudoelements): localize expensive typeclass #9156

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(category/abelian/pseudoelements): localize expensive typeclass #9156

wants to merge 2 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented Sep 12, 2021 •
edited

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Sep 12, 2021
@fpvandoorn
Copy link
Member

could you add a comment somewhere to explain why we put this in a locale?

@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 12, 2021
bors bot pushed a commit that referenced this pull request Sep 12, 2021
@semorrison
chore(category/abelian/pseudoelements): localize expensive typeclass (#…
a7d872f 
…9156)

Per @fpvandoorn's [new linter](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/type-class.20loops.20in.20category.20theory).
@bors
Copy link

bors bot commented Sep 12, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(category/abelian/pseudoelements): localize expensive typeclass [Merged by Bors] - chore(category/abelian/pseudoelements): localize expensive typeclass Sep 12, 2021
@bors bors bot closed this Sep 12, 2021
@bors bors bot deleted the fix_pseudoelement branch September 12, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@semorrison @fpvandoorn