[Merged by Bors] - chore(ring_theory/dedekind_domain): speed up dedekind_domain.lean
#9232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: sgouezel <sebastien.gouezel@univ-rennes1.fr> Co-Authored-By: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Vierkantor
added
the
awaiting-review
|
✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
The queue is empty but the PR builders are busy, so let's just throw this over to nael and hope bors r+ |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 16, 2021
…9232) @eric-wieser [noticed that `dedekind_domain.lean`](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Timeouts.20in.20ring_theory.2Fdedekind_domain.2Elean.3A664.3A9) was compiling slowly and on the verge of a timeout. @kbuzzard, @sgouezel and I reworked some definitions to make everything elaborate much faster: `is_dedekind_domain_inv_iff`, `mul_inv_cancel_of_le_one` and `ideal.unique_factorization_monoid` went from over 10 seconds on my machine to less than 3 seconds. No other declaration in that file now takes over 2 seconds on my machine. Apart from the three declarations getting new proofs, I also made the following changes: * The operations on `localization` (`has_add`, `has_mul`, `has_one`, `has_zero`, `has_neg` and `localization.inv`) are now `@[irreducible]` * `fraction_ring.field` copies its field from `localization.comm_ring` for faster unification (less relevant after the previous change) * Added `fractional_ideal.map_mem_map` and `fractional_ideal.map_injective` to simplify the proof of `is_dedekind_domain_inv_iff`.
|
Build failed: |
|
Well that at least got us an answer quickly! |
eric-wieser
reviewed
Sep 16, 2021
eric-wieser
added
awaiting-review
This should ensure the API for `localization` is contained within `mk`/`mk_eq_mk_iff`/`rec`, no more `quotient` defs escaping
This halves the elaboration time of `matrix.mul_vec_eq_zero_iff`
Vierkantor
commented
Sep 22, 2021
Vierkantor
commented
Sep 22, 2021
Vierkantor
added
awaiting-review
|
I'm going to re-request a review since a lot changed since the previous one. |
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 22, 2021
…9232) @eric-wieser [noticed that `dedekind_domain.lean`](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Timeouts.20in.20ring_theory.2Fdedekind_domain.2Elean.3A664.3A9) was compiling slowly and on the verge of a timeout. @kbuzzard, @sgouezel and I reworked some definitions to make everything elaborate much faster: `is_dedekind_domain_inv_iff`, `mul_inv_cancel_of_le_one` and `ideal.unique_factorization_monoid` went from over 10 seconds on my machine to less than 3 seconds. No other declaration in that file now takes over 2 seconds on my machine. Apart from the three declarations getting new proofs, I also made the following changes: * The operations on `localization` (`has_add`, `has_mul`, `has_one`, `has_zero`, `has_neg`, `npow` and `localization.inv`) are now `@[irreducible]` * `fraction_ring.field` copies its field from `localization.comm_ring` for faster unification (less relevant after the previous change) * Added `fractional_ideal.map_mem_map` and `fractional_ideal.map_injective` to simplify the proof of `is_dedekind_domain_inv_iff`. * Split the proof of `matrix.exists_mul_vec_eq_zero_iff` into two parts to speed it up Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
dedekind_domain.leandedekind_domain.lean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eric-wieser noticed that
dedekind_domain.leanwas compiling slowly and on the verge of a timeout. @kbuzzard, @sgouezel and I reworked some definitions to make everything elaborate much faster:is_dedekind_domain_inv_iff,mul_inv_cancel_of_le_oneandideal.unique_factorization_monoidwent from over 10 seconds on my machine to less than 3 seconds. No other declaration in that file now takes over 2 seconds on my machine.Apart from the three declarations getting new proofs, I also made the following changes:
localization(has_add,has_mul,has_one,has_zero,has_neg,npowandlocalization.inv) are now@[irreducible]fraction_ring.fieldcopies its field fromlocalization.comm_ringfor faster unification (less relevant after the previous change)fractional_ideal.map_mem_mapandfractional_ideal.map_injectiveto simplify the proof ofis_dedekind_domain_inv_iff.matrix.exists_mul_vec_eq_zero_iffinto two parts to speed it up