Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ereal): added useful lemmas #9313

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(ereal): added useful lemmas #9313

wants to merge 5 commits into from

Conversation

mmasdeu
Copy link
Collaborator

@mmasdeu mmasdeu commented Sep 20, 2021

Some small addition to the api for ereals.

Open in Gitpod

@mmasdeu
feat(ereal): added useful lemmas
9eb76c2 
Some small addition to the api for ereals.
@mmasdeu
feat(ereal)
30c2788 
Changed names of two lemmas, and shortened their proofs
@mmasdeu
feat(ereal): delete redundant lemmas
fadd313
@mmasdeu @eric-wieser
Update src/data/real/ereal.lean
b6a4d88 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
eric-wieser approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will let someone else have a final pass.

src/data/real/ereal.lean Show resolved Hide resolved
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Sep 21, 2021
@sgouezel
Copy link
Collaborator

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 23, 2021
bors bot pushed a commit that referenced this pull request Sep 23, 2021
@mmasdeu @eric-wieser
feat(ereal): added useful lemmas (#9313)
21c6a0e 
Some small addition to the api for ereals.





Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Sep 23, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 23, 2021
@mmasdeu @eric-wieser
feat(ereal): added useful lemmas (#9313)
0243da3 
Some small addition to the api for ereals.





Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Sep 23, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ereal): added useful lemmas [Merged by Bors] - feat(ereal): added useful lemmas Sep 23, 2021
@bors bors bot closed this Sep 23, 2021
@bors bors bot deleted the ereal_lemmas branch September 23, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmasdeu @sgouezel @eric-wieser