[Merged by Bors] - refactor(algebra/order/ring,data/complex): redefine ordered_comm_ring and complex order
#9420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
awaiting-review
semorrison
reviewed
Sep 28, 2021
|
This is great! bors d+ |
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 28, 2021
…g` and complex order (#9420) * `ordered_comm_ring` no longer extends `ordered_comm_semiring`. We add an instance `ordered_comm_ring.to_ordered_comm_semiring` instead. * redefine complex order in terms of `re` and `im` instead of existence of a nonnegative real number. * simplify `has_star.star` on `complex` to `conj`; * rename `complex.complex_partial_order` etc to `complex.partial_order` etc, make them protected.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
ordered_comm_ring and complex orderordered_comm_ring and complex order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ordered_comm_ringno longer extendsordered_comm_semiring.We add an instance
ordered_comm_ring.to_ordered_comm_semiringinstead.reandiminstead of existence of a nonnegative real number.has_star.staroncomplextoconj;complex.complex_partial_orderetc tocomplex.partial_orderetc, make them protected.