Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(category_theory/sites/*): Cover-lifting functors on sites #9431

Closed
wants to merge 37 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Sep 28, 2021

This PR defines cover-liftings functors between sites, and proves that Ran F.op maps sheaves to sheaves for cover-lifting functors F.
This will probably be needed when we want to glue B-sheaves into sheaves.


By the way, is there a better name for Ran_is_sheaf? It sounds quite odd now.

Open in Gitpod

@erdOne erdOne added the awaiting-review The author would like community review of the PR label Sep 28, 2021
src/category_theory/sites/cocontinuous.lean Outdated Show resolved Hide resolved
src/category_theory/sites/cocontinuous.lean Outdated Show resolved Hide resolved
src/category_theory/sites/cocontinuous.lean Outdated Show resolved Hide resolved
Given a structured arrow `X ⟶ F(U)`, and an arrow `U ⟶ Y`, we can construct a morphism of
structured arrow given by `(X ⟶ F(U)) ⟶ (X ⟶ F(U) ⟶ F(Y))`.
-/
def hom_mk' {F : C ⥤ D} {X : D} {Y : C}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this definition? I think it looks a little out of place on its own...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried not to, but I couldn't find a better way to construct those kind of morphisms without using have everywhere.

@erdOne erdOne changed the title feat(category_theory/sites/*): Cocontinuous functor on sites feat(category_theory/sites/*): Cocontinuous functors on sites Sep 29, 2021
src/category_theory/sites/cocontinuous.lean Outdated Show resolved Hide resolved
src/category_theory/sites/cocontinuous.lean Outdated Show resolved Hide resolved
src/category_theory/sites/cocontinuous.lean Outdated Show resolved Hide resolved
src/category_theory/sites/cocontinuous.lean Outdated Show resolved Hide resolved
src/category_theory/sites/cocontinuous.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 30, 2021
erdOne and others added 5 commits September 30, 2021 14:36
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
Copy link
Collaborator

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments from a brief read, I'll take a closer look once these (and Johan's) comments have been addressed.

src/category_theory/sites/cocontinuous.lean Outdated Show resolved Hide resolved
src/category_theory/sites/cocontinuous.lean Outdated Show resolved Hide resolved
src/category_theory/sites/cocontinuous.lean Outdated Show resolved Hide resolved
src/category_theory/sites/cocontinuous.lean Outdated Show resolved Hide resolved
src/category_theory/sites/cocontinuous.lean Outdated Show resolved Hide resolved
src/category_theory/sites/sieves.lean Outdated Show resolved Hide resolved
src/category_theory/sites/sieves.lean Outdated Show resolved Hide resolved
src/category_theory/sites/sieves.lean Outdated Show resolved Hide resolved
src/category_theory/sites/sheaf_of_types.lean Outdated Show resolved Hide resolved
erdOne and others added 5 commits October 1, 2021 10:23
Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
src/category_theory/sites/sieves.lean Outdated Show resolved Hide resolved
src/category_theory/sites/cover_lifting.lean Outdated Show resolved Hide resolved
Co-authored-by: Johan Commelin <johan@commelin.net>
@jcommelin
Copy link
Member

This is starting to look good. I have one question: how responsive is the file? You prove some things using tidy and simp. Are these snappy? If not, please replace tidy with the output of tidy? and simp with the output of squeeze_simp.

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 2, 2021
@erdOne
Copy link
Member Author

erdOne commented Oct 2, 2021

It is indeed not that responsive, but replacing the simps to sorrys doesn't seem to change the running time at all, so I assume that the bottleneck is not at the simps.

@erdOne erdOne added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 2, 2021
src/category_theory/sites/sieves.lean Outdated Show resolved Hide resolved
src/category_theory/sites/sieves.lean Show resolved Hide resolved
src/category_theory/sites/sieves.lean Outdated Show resolved Hide resolved
src/category_theory/sites/sheaf_of_types.lean Outdated Show resolved Hide resolved
src/category_theory/sites/sheaf_of_types.lean Outdated Show resolved Hide resolved
src/category_theory/sites/sheaf_of_types.lean Outdated Show resolved Hide resolved
src/category_theory/sites/sheaf_of_types.lean Outdated Show resolved Hide resolved
erdOne and others added 7 commits October 3, 2021 21:34
Co-authored-by: Justus Springer <50165510+justus-springer@users.noreply.github.com>
Co-authored-by: Justus Springer <50165510+justus-springer@users.noreply.github.com>
Co-authored-by: Justus Springer <50165510+justus-springer@users.noreply.github.com>
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 4, 2021
bors bot pushed a commit that referenced this pull request Oct 4, 2021
This PR defines cover-liftings functors between sites, and proves that `Ran F.op` maps sheaves to sheaves for cover-lifting functors `F`. 
This will probably be needed when we want to glue B-sheaves into sheaves.



Co-authored-by: erdOne <36414270+erdOne@users.noreply.github.com>
@bors
Copy link

bors bot commented Oct 4, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/sites/*): Cover-lifting functors on sites [Merged by Bors] - feat(category_theory/sites/*): Cover-lifting functors on sites Oct 4, 2021
@bors bors bot closed this Oct 4, 2021
@bors bors bot deleted the cocontinuous_functor_on_sites branch October 4, 2021 09:48
@alreadydone
Copy link
Collaborator

alreadydone commented Nov 13, 2021

It would be an interesting project to define the structure sheaf on Spec using this PR. Endow the ring with a category structure and a Grothendieck topology, so that basic_open is a cover-lifting functor to opens (prime_spectrum R). This could avoid Reid Barton's trick to avoid axiom of choice in the first definitions in Schemes in Lean (no need to identify R[1/f] with R[1/g] when D(f)=D(g)), and the construction would end up similar to the second definition: without the implicit sheafification in Hartshorne's construction, we would need the generalized 00EJ (4.4 in paper) to prove the R[1/f] presheaf on the "ring site" is a sheaf, then transfer it to the structure sheaf using this PR.

However, this approach seems not applicable for the localization functor (see p.7), so I'm not in favor of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants