[Merged by Bors] - feat(linear_algebra/affine_space/barycentric_coords): define barycentric coordinates #9472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ocfnash
commented
Sep 30, 2021
ocfnash
commented
ocfnash
added
the
awaiting-review
eric-wieser
reviewed
Sep 30, 2021
eric-wieser
reviewed
Sep 30, 2021
Comment on lines
+169
to
+171
| /-- The sum of the coordinates of an element `m : M` with respect to a basis. -/ | ||
| noncomputable def sum_coords : M →ₗ[R] R := | ||
| finsupp.lsum ℕ (λ i, linear_map.id) ∘ₗ (b.repr : M →ₗ[R] ι →₀ R) |
There was a problem hiding this comment.
Do you have a use-case in mind outside of barycentric coordinates? I'd be inclined to put this in that file if not.
There was a problem hiding this comment.
On reflection I think you're right but maybe I'll canvass an opinion from @Vierkantor before I move things.
(Edit: to answer your question, I do not have another use-case in mind though I expect there will be others eventually.)
semorrison
added
awaiting-author
ocfnash
added
awaiting-review
PatrickMassot
added
awaiting-author
ocfnash
added
awaiting-review
PatrickMassot
added
ready-for-bors
and removed
awaiting-review
|
Thanks 🎉 bors merge |
github-actions
bot
added
the
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.