Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(group_theory/double_cosets): definition of double cosets and some basic lemmas. #9490

Closed
wants to merge 42 commits into from

Conversation

CBirkbeck
Copy link
Collaborator

@CBirkbeck CBirkbeck commented Oct 1, 2021

This contains the definition of double cosets and some basic lemmas about them, such as "the whole group is the disjoint union of its double cosets" and relationship to usual group quotients.


Open in Gitpod

@semorrison semorrison added the WIP Work in progress label Oct 2, 2021
@CBirkbeck CBirkbeck added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Oct 15, 2021
@CBirkbeck CBirkbeck marked this pull request as ready for review October 15, 2021 12:03
@CBirkbeck CBirkbeck changed the title start on double cosets feat(group_theory/double_cosets): definition of double cosets and some basic lemmas. Oct 19, 2021
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've flagged a couple of stylistic issues. Please extrapolate my comments to the rest of the file.

src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 25, 2021
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
@Vierkantor Vierkantor self-requested a review February 17, 2022 10:42
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a big amount of comments, but they are mostly stylistic.

src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
src/group_theory/double_coset.lean Outdated Show resolved Hide resolved
@Vierkantor Vierkantor added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 17, 2022
@CBirkbeck CBirkbeck added awaiting-review The author would like community review of the PR WIP Work in progress and removed awaiting-author A reviewer has asked the author a question or requested changes awaiting-review The author would like community review of the PR WIP Work in progress labels Feb 23, 2022
Comment on lines +96 to +112
lemma subgroup_mul_singleton {H : subgroup G} {h : G} (hh : h ∈ H) :
(H : set G) * {h} = H :=
begin
refine le_antisymm _ (λ h' hh',
⟨h' * h⁻¹, h, H.mul_mem hh' (H.inv_mem hh), rfl, inv_mul_cancel_right h' h⟩),
rintros _ ⟨h', h, hh', rfl : _ = _, rfl⟩,
exact H.mul_mem hh' hh,
end

lemma singleton_mul_subgroup {H : subgroup G} {h : G} (hh : h ∈ H) :
{h} * (H : set G) = H :=
begin
refine le_antisymm _ (λ h' hh', ⟨h, h⁻¹ * h', rfl, H.mul_mem (H.inv_mem hh) hh',
mul_inv_cancel_left h h'⟩),
rintros _ ⟨h, h', rfl : _ = _, hh', rfl⟩,
exact H.mul_mem hh hh',
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work on submonoids too, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it? the proof uses inverses.

Copy link
Collaborator Author

@CBirkbeck CBirkbeck Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually 2 * ℕ\{0} isnt ℕ\{0} so I dont think it works. unless the defn of monoid is not what I think it is.

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 3, 2022
@CBirkbeck CBirkbeck added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 8, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 10, 2022
bors bot pushed a commit that referenced this pull request Mar 10, 2022
…e basic lemmas. (#9490)

This contains the definition of double cosets and some basic lemmas about them, such as "the whole group is the disjoint union of its double cosets" and relationship to usual group quotients.
@bors
Copy link

bors bot commented Mar 10, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(group_theory/double_cosets): definition of double cosets and some basic lemmas. [Merged by Bors] - feat(group_theory/double_cosets): definition of double cosets and some basic lemmas. Mar 10, 2022
@bors bors bot closed this Mar 10, 2022
@bors bors bot deleted the double_cosets branch March 10, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants