New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(group_theory/double_cosets): definition of double cosets and some basic lemmas. #9490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've flagged a couple of stylistic issues. Please extrapolate my comments to the rest of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a big amount of comments, but they are mostly stylistic.
lemma subgroup_mul_singleton {H : subgroup G} {h : G} (hh : h ∈ H) : | ||
(H : set G) * {h} = H := | ||
begin | ||
refine le_antisymm _ (λ h' hh', | ||
⟨h' * h⁻¹, h, H.mul_mem hh' (H.inv_mem hh), rfl, inv_mul_cancel_right h' h⟩), | ||
rintros _ ⟨h', h, hh', rfl : _ = _, rfl⟩, | ||
exact H.mul_mem hh' hh, | ||
end | ||
|
||
lemma singleton_mul_subgroup {H : subgroup G} {h : G} (hh : h ∈ H) : | ||
{h} * (H : set G) = H := | ||
begin | ||
refine le_antisymm _ (λ h' hh', ⟨h, h⁻¹ * h', rfl, H.mul_mem (H.inv_mem hh) hh', | ||
mul_inv_cancel_left h h'⟩), | ||
rintros _ ⟨h, h', rfl : _ = _, hh', rfl⟩, | ||
exact H.mul_mem hh hh', | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work on submonoids too, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it? the proof uses inverses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually 2 * ℕ\{0}
isnt ℕ\{0}
so I dont think it works. unless the defn of monoid is not what I think it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
…e basic lemmas. (#9490) This contains the definition of double cosets and some basic lemmas about them, such as "the whole group is the disjoint union of its double cosets" and relationship to usual group quotients.
Pull request successfully merged into master. Build succeeded: |
This contains the definition of double cosets and some basic lemmas about them, such as "the whole group is the disjoint union of its double cosets" and relationship to usual group quotients.